Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] tab focus #35022

Merged
merged 1 commit into from
Aug 4, 2021
Merged

[4.0] tab focus #35022

merged 1 commit into from
Aug 4, 2021

Conversation

brianteeman
Copy link
Contributor

When navigating with the keyboard a focus outline is applied to the tabs
tabs

However as can be seen in this enlargement the outline is cut on the right.
image

This PR adjusts the z-index to prevent that
image

There is a scss change so you will need to rebuild it for testing

When navigating with the keyboard a focus outline is applied to the tabs

However as can be seen in this enlargement the outline is cut on the right.

This PR adjusts the z-index to prevent that
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Aug 2, 2021
@ChristineWk
Copy link

ChristineWk commented Aug 2, 2021

I have tested this item ✅ successfully on 598bca5

First try with Prebuilt Package was unsuccessful.
But after Clearing Browser Cache (FF) it was OK then.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35022.

@RickR2H
Copy link
Member

RickR2H commented Aug 2, 2021

I have tested this item ✅ successfully on 598bca5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35022.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35022.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 2, 2021
@wilsonge wilsonge merged commit 59649f7 into joomla:4.0-dev Aug 4, 2021
@wilsonge
Copy link
Contributor

wilsonge commented Aug 4, 2021

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 4, 2021
@brianteeman
Copy link
Contributor Author

Thank you

@brianteeman brianteeman deleted the focus branch August 5, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants