Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Added php8 to list of filtered extensions #35001

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

SniperSister
Copy link
Contributor

Summary of Changes

Added PHP8 to the hardcoded list of executables

Testing Instructions

Verify by code review

@richard67
Copy link
Member

I have tested this item ✅ successfully on 4d73fbc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35001.

@richard67 richard67 added this to the Joomla 4.0 milestone Jul 31, 2021
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 4d73fbc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35001.

@SniperSister SniperSister added the RTC This Pull Request is Ready To Commit label Jul 31, 2021
@joomla-cms-bot joomla-cms-bot removed this from the Joomla 4.0 milestone Jul 31, 2021
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35001.

@richard67
Copy link
Member

@SniperSister It's not sufficient to set the RTC label on GitHub to get the right status shown in the issue tracker. It needs to use the tracker and change status there. I've done that here now.

@brianteeman
Copy link
Contributor

Why is the list shorter than in #34999

@brianteeman
Copy link
Contributor

I have not tested this item.

reverting my successful test


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35001.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 4.0 milestone Jul 31, 2021
@richard67
Copy link
Member

Back to pending.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35001.

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 31, 2021
@richard67
Copy link
Member

Why is the list shorter than in #34999

These lists serve different purpose. The one in #34999 is for media so it e.g. disallows "js", while here it is for the input filter so we shall not disallow js because we don't know what the field might be used for.

@brianteeman
Copy link
Contributor

#34999 blocks .php
#35001 blocks .php, .php3, .php4, .php5, .php6, .php7, .php8

I don't see the logic behind this difference

@richard67
Copy link
Member

#34999 blocks .php
#35001 blocks .php, .php3, .php4, .php5, .php6, .php7, .php8

I don't see the logic behind this difference

@brianteeman Me neither ... but that's the other way round. You had complained the list here in #35001 is shorter than the other one in #34999 .

=> Ping @SniperSister : Should be add .php3, .php4, .php5, .php6, .php7, .php8 and possibly others to #34999 , too?

@brianteeman
Copy link
Contributor

@brianteeman Me neither ... but that's the other way round. You had complained the list here in #35001 is shorter than the other one in #34999 .

Because the entire list is shorter ;)

Just this part is longer

@richard67
Copy link
Member

Because the entire list is shorter ;)

@brianteeman About this aspect see my comment above #35001 (comment) .

@brianteeman
Copy link
Contributor

i disagree completely with that comment - its either secure or not. its not dependant on where it is used.

@richard67 richard67 added this to the Joomla 4.0 milestone Jul 31, 2021
@RickR2H
Copy link
Member

RickR2H commented Aug 2, 2021

I have tested this item ✅ successfully on 4d73fbc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35001.

@richard67 richard67 added the RTC This Pull Request is Ready To Commit label Aug 2, 2021
@joomla-cms-bot joomla-cms-bot removed this from the Joomla 4.0 milestone Aug 2, 2021
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35001.

@richard67 richard67 added this to the Joomla 4.0 milestone Aug 2, 2021
@brianteeman
Copy link
Contributor

I have tested this item 🔴 unsuccessfully on 4d73fbc

The reasoning behind this list makes it incomplete


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35001.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 4.0 milestone Aug 2, 2021
@richard67
Copy link
Member

Back to pending.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35001.

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 2, 2021
@RickR2H
Copy link
Member

RickR2H commented Aug 2, 2021

@brianteeman @richard67 This PR is set as Release Blocker... But is this really the case?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35001.

@wilsonge
Copy link
Contributor

wilsonge commented Aug 4, 2021

Merging this one. And #34999 will clean up the discrepancies in the lists

@wilsonge wilsonge merged commit 2ae50ce into joomla:4.0-dev Aug 4, 2021
@wilsonge wilsonge added this to the Joomla 4.0 milestone Aug 4, 2021
@SniperSister SniperSister deleted the 4x-php8filter branch March 3, 2022 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants