-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Added php8 to list of filtered extensions #35001
Conversation
I have tested this item ✅ successfully on 4d73fbc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35001. |
I have tested this item ✅ successfully on 4d73fbc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35001. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35001. |
@SniperSister It's not sufficient to set the RTC label on GitHub to get the right status shown in the issue tracker. It needs to use the tracker and change status there. I've done that here now. |
Why is the list shorter than in #34999 |
I have not tested this item. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35001. |
Back to pending. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35001. |
@brianteeman Me neither ... but that's the other way round. You had complained the list here in #35001 is shorter than the other one in #34999 . => Ping @SniperSister : Should be add .php3, .php4, .php5, .php6, .php7, .php8 and possibly others to #34999 , too? |
Because the entire list is shorter ;) Just this part is longer |
@brianteeman About this aspect see my comment above #35001 (comment) . |
i disagree completely with that comment - its either secure or not. its not dependant on where it is used. |
I have tested this item ✅ successfully on 4d73fbc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35001. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35001. |
I have tested this item 🔴 unsuccessfully on 4d73fbc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35001. |
Back to pending. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35001. |
@brianteeman @richard67 This PR is set as Release Blocker... But is this really the case? This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35001. |
Merging this one. And #34999 will clean up the discrepancies in the lists |
Summary of Changes
Added PHP8 to the hardcoded list of executables
Testing Instructions
Verify by code review