-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Crowdin comments #34671
[4.0] Crowdin comments #34671
Conversation
This PR updates the comments in language strings to a format that crowdin understands as requested by @conconnl joomla/core-translations#1 Basically comments are moved to the end of the line in the *.ini Note comments which are not for translators such as a comment used to indicate a grooup of strings have not been changed
@HLeithner & @zero-24 Please look at it and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest looks good
Thanks for checking @HLeithner - perfectly correct and updated |
Co-authored-by: Harald Leithner <[email protected]>
I think we looked into this already years ago and I know it didn't work at that time. I don't exactly remember the reasons however. |
I'm just doing the work that was requested - no need for the thumbs |
Already tested before submitting a pr |
conflicts resolved |
I have tested this item ✅ successfully on e56f3e4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34671. |
Conflicts resolved again. Please either merge this PR before the freeze that was requested by the language co-ordinators or close it. Not wasting my time any more |
If tools around this PR breaks, we have to fix them or retire them if no longer used. Crowdin is our current translation platform and we should support it as good as we can. |
Thanks @HLeithner over to you now @conconnl |
This PR updates the comments in language strings to a format that crowdin understands as requested by @conconnl joomla/core-translations#1
Basically comments are moved to the end of the line in the *.ini
Note comments which are not for translators such as a comment used to indicate a group of strings have not been changed