Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Crowdin comments #34671

Merged
merged 5 commits into from
Jul 12, 2021
Merged

[4.0] Crowdin comments #34671

merged 5 commits into from
Jul 12, 2021

Conversation

brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Jun 30, 2021

This PR updates the comments in language strings to a format that crowdin understands as requested by @conconnl joomla/core-translations#1

Basically comments are moved to the end of the line in the *.ini

Note comments which are not for translators such as a comment used to indicate a group of strings have not been changed

This PR updates the comments in language strings to a format that crowdin understands as requested by @conconnl joomla/core-translations#1

Basically comments are moved to the end of the line in the *.ini

Note comments which are not for translators such as a comment used to indicate a grooup of strings have not been changed
@conconnl
Copy link
Member

@HLeithner & @zero-24 Please look at it and merge.

Copy link
Member

@HLeithner HLeithner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks good

administrator/language/en-GB/joomla.ini Outdated Show resolved Hide resolved
administrator/language/en-GB/lib_joomla.ini Outdated Show resolved Hide resolved
api/language/en-GB/joomla.ini Outdated Show resolved Hide resolved
language/en-GB/joomla.ini Outdated Show resolved Hide resolved
language/en-GB/lib_joomla.ini Outdated Show resolved Hide resolved
@brianteeman
Copy link
Contributor Author

Thanks for checking @HLeithner - perfectly correct and updated

@Bakual
Copy link
Contributor

Bakual commented Jul 1, 2021

I think we looked into this already years ago and I know it didn't work at that time. I don't exactly remember the reasons however.
One was certainly that com_localise doesn't recognise those comments, but I think at that time Joomla couldn't handle them (language files broke I think). So please make sure everything related to language handling works when having the comments at the end (eg debugging languages)

@brianteeman
Copy link
Contributor Author

I'm just doing the work that was requested - no need for the thumbs

@brianteeman brianteeman requested a review from HLeithner July 2, 2021 07:50
@brianteeman
Copy link
Contributor Author

So please make sure everything related to language handling works when having the comments at the end (eg debugging languages)

Already tested before submitting a pr

@brianteeman
Copy link
Contributor Author

conflicts resolved

@obuisard
Copy link
Contributor

obuisard commented Jul 9, 2021

I have tested this item ✅ successfully on e56f3e4

The changes have no incidence in the outputs (like, for instance, creating an instance of the footer module)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34671.

@brianteeman
Copy link
Contributor Author

Conflicts resolved again.

Please either merge this PR before the freeze that was requested by the language co-ordinators or close it. Not wasting my time any more

@HLeithner HLeithner merged commit 8cb8123 into joomla:4.0-dev Jul 12, 2021
@HLeithner
Copy link
Member

If tools around this PR breaks, we have to fix them or retire them if no longer used. Crowdin is our current translation platform and we should support it as good as we can.

@brianteeman
Copy link
Contributor Author

Thanks @HLeithner

over to you now @conconnl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants