[4.0] mod_popular with disabled hits

[brianteeman]

When hits are disabled for articles (in the article options) it makes no sense to display the Most Read Articles module in the site or admin as the contents will never be updated.

This PR changes the output of the module so that instead of a list of non-updating articles a message is displayed.

Site Module

Admin Module

[chmst]

The module seems to be very old and there are only few use cases when it makes sense, with or without hit counting. I suggest removing it from the dashboard for new installations. @richard67 what do you think?

[richard67]

The module seems to be very old and there are only few use cases when it makes sense, with or without hit counting. I suggest removing it from the dashboard for new installations. @richard67 what do you think?

@chmst I think that with hit count it sill makes sense and I would like to have that module on my dashboard because I have it for my homepage, too. But that's just my personal opinion, I have nothing to decide and I don't want to have anything to decide.

[brianteeman]

I actually use it a lot - so maybe others so as well - dont really care if its default or not. Either way its beyond the scope of this PR to remove it

[chmst]

It is not in scope of this PR, just a matter of taste.

[brianteeman]

we really have to get out of the habit of out of scope comments. Far too often they completely detract from the actual PR. my 2c

[Abernyte-Git]

I have tested this item ✅ successfully on 1f63709

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34257.}

[ghost]

I have tested this item ✅ successfully on 1f63709

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34257.}

[Quy]

Should the module be displayed on the front end in this case?

[brianteeman]

Absolutely yes. Think like a user.

I turn off hits in January. In December I decide to add the module but it doesn't appear anywhere - joomla is broken.
This way it appears and they are informed that they need to re-enable hits

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34257.}

[chmst]

Thanks!

[brianteeman]

Thanks

[brianteeman]

@SharkyKZ is it your mission in life to just sit there and put the thumbs down. This is an open repo - if you have a comment to make then please do so.

[SharkyKZ]

With maintainers like these it's pointless.

[richard67]

Thanks for the flowers.

[brianteeman]

I dont believe anyone is a mind reader. If there is something wrong then say it

[brianteeman]

thats why you have to speak and not thumbs