-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4] Add system information quickicon to Home Dashboard #33886
Conversation
This comment was marked as abuse.
This comment was marked as abuse.
@PhilETaylor You should change also the params for the quickicon in the The params there should be exactly the same as in the base.sql for the same module. But as I can see the params are outdated there also for other quickicons, e.g. "header_icon" values differ to a new installation. So maybe I have to make a separate PR for that if you don't want to clean that up here. |
This comment was marked as abuse.
This comment was marked as abuse.
The next question is if something to be done for updating 4.0 Beta 7 or earlier. But that's always a hairy thing, updating json parameters, so I have to think about that. |
This comment was marked as abuse.
This comment was marked as abuse.
I wanted to put at least some awareness on these update aspects because people are messing around much recently with params here and there and don't care about the update script, so what I find when digging deeper is a mess. |
This comment was marked as abuse.
This comment was marked as abuse.
Massively depends on your screen size. On my screen this PR just created extra space |
We want to have a 4.0 RC soon and things like this PR may look easy at a first look .. but only if you don't care about updating and leave all database stuff alone. Do we really need this so soon before we want to go RC? I currently think all that stuff should be labelled as new feature and shifted to 4.1. We should focus on bugs now. But that's just my personal opinion. |
This comment was marked as abuse.
This comment was marked as abuse.
Much more interested in your mail template thing |
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
@PhilETaylor That's right, and that's much appreciated, and I haven't said anything else. |
There is another PR that adds a lot more optional quickicons but I think it was merged into 4.1 as the maintainers deemed it a new feature |
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
I'd say it's something in between those 2 :-) |
This comment was marked as abuse.
This comment was marked as abuse.
@PhilETaylor It's only me being a normal maintainer and not official speaker so I don't want to make official statements. All I can say is we are close to it. |
Pull Request for Issue # .
Summary of Changes
Fill the wasted space in the System module on Home Dashboard, by default, with 4 boxes and not just 3 by introducing the System Information quick icon (after all, this is the SYSTEM module of quick icons!)
Testing Instructions
See Home Dashboard - toggle the new icon on/off
Actual result BEFORE applying this Pull Request
A Missed opportunity of space
Expected result AFTER applying this Pull Request
By default, on new installation, there are now 4 icons in the System box on Home Dashboard.
There is a new option that can be toggled on the edit screen:
Documentation Changes Required