Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4] Add system information quickicon to Home Dashboard #33886

Closed
wants to merge 2 commits into from
Closed

[4] Add system information quickicon to Home Dashboard #33886

wants to merge 2 commits into from

Conversation

PhilETaylor
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

Fill the wasted space in the System module on Home Dashboard, by default, with 4 boxes and not just 3 by introducing the System Information quick icon (after all, this is the SYSTEM module of quick icons!)

Testing Instructions

See Home Dashboard - toggle the new icon on/off

Actual result BEFORE applying this Pull Request

A Missed opportunity of space

Screenshot 2021-05-14 at 21 46 02

Expected result AFTER applying this Pull Request

By default, on new installation, there are now 4 icons in the System box on Home Dashboard.

Screenshot 2021-05-14 at 21 44 28

There is a new option that can be toggled on the edit screen:

Screenshot 2021-05-14 at 21 42 17

Documentation Changes Required

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels May 14, 2021
@PhilETaylor

This comment was marked as abuse.

@richard67
Copy link
Member

richard67 commented May 14, 2021

@PhilETaylor You should change also the params for the quickicon in the 4.0.0-2019-07-13.sql script so they are created in the right way when updating from 3.10-dev:

https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_admin/sql/updates/mysql/4.0.0-2019-07-13.sql#L70

https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_admin/sql/updates/postgresql/4.0.0-2019-07-13.sql#L69

The params there should be exactly the same as in the base.sql for the same module.

But as I can see the params are outdated there also for other quickicons, e.g. "header_icon" values differ to a new installation.

So maybe I have to make a separate PR for that if you don't want to clean that up here.

@PhilETaylor

This comment was marked as abuse.

@richard67
Copy link
Member

The next question is if something to be done for updating 4.0 Beta 7 or earlier. But that's always a hairy thing, updating json parameters, so I have to think about that.

@PhilETaylor

This comment was marked as abuse.

@richard67
Copy link
Member

I wanted to put at least some awareness on these update aspects because people are messing around much recently with params here and there and don't care about the update script, so what I find when digging deeper is a mess.

@PhilETaylor

This comment was marked as abuse.

@brianteeman
Copy link
Contributor

A Missed opportunity of space

Massively depends on your screen size.

On my screen this PR just created extra space

@richard67
Copy link
Member

We want to have a 4.0 RC soon and things like this PR may look easy at a first look .. but only if you don't care about updating and leave all database stuff alone.

Do we really need this so soon before we want to go RC?

I currently think all that stuff should be labelled as new feature and shifted to 4.1.

We should focus on bugs now.

But that's just my personal opinion.

@PhilETaylor

This comment was marked as abuse.

@brianteeman
Copy link
Contributor

Much more interested in your mail template thing

@PhilETaylor

This comment was marked as abuse.

@PhilETaylor PhilETaylor changed the base branch from 4.0-dev to 4.1-dev May 14, 2021 21:29
@PhilETaylor PhilETaylor requested a review from wilsonge as a code owner May 14, 2021 21:29
@PhilETaylor PhilETaylor changed the base branch from 4.1-dev to 4.0-dev May 14, 2021 21:30
@PhilETaylor

This comment was marked as abuse.

@richard67
Copy link
Member

I think the actual maths will show that I have reported and worked on many bugs as well as things like this.

@PhilETaylor That's right, and that's much appreciated, and I haven't said anything else.

@brianteeman
Copy link
Contributor

There is another PR that adds a lot more optional quickicons but I think it was merged into 4.1 as the maintainers deemed it a new feature

@richard67
Copy link
Member

richard67 commented May 14, 2021

The one which was merged into 4.1-dev was a small one, #32223 . The bigger one for 4.1-dev is still open: #32671 .

@PhilETaylor

This comment was marked as abuse.

@PhilETaylor

This comment was marked as abuse.

@PhilETaylor

This comment was marked as abuse.

@richard67
Copy link
Member

Is there actually a decision and a date or is this pie in the sky still?

I'd say it's something in between those 2 :-)

@PhilETaylor

This comment was marked as abuse.

@richard67
Copy link
Member

@PhilETaylor It's only me being a normal maintainer and not official speaker so I don't want to make official statements. All I can say is we are close to it.

@PhilETaylor

This comment was marked as abuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants