Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] GMP system info #32289

Closed
wants to merge 1 commit into from
Closed

[4.0] GMP system info #32289

wants to merge 1 commit into from

Conversation

brianteeman
Copy link
Contributor

As webauthn plugin uses the php GMP extension it made sense to add a check for this in the system info.

There is already code that handles the error message #29731 this is just for the system info list.

Perhaps it should be added to the preinstall/preupdate checks as well as a recommendation (not required) @wilsonge @zero-24

/administrator/index.php?option=com_admin&view=sysinfo

image

As webauthn plugin uses the php GMP extension it made ense to add a check for this in the system info.
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Feb 3, 2021
@Quy
Copy link
Contributor

Quy commented Feb 3, 2021

I have tested this item ✅ successfully on fdac7b8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32289.

@toivo
Copy link
Contributor

toivo commented Feb 3, 2021

I have tested this item ✅ successfully on fdac7b8

Tested successfully in Beta8-dev of 3 February using PHP 8.0.1.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32289.

@brianteeman brianteeman closed this Feb 3, 2021
@brianteeman brianteeman deleted the gmp branch February 3, 2021 19:26
@brianteeman
Copy link
Contributor Author

To be clear as I obviously wasnt explaining myself correctly.

If my proposal to use extension_loaded to determine if gmp is enabled in php is not suitable then dont we also have to correct all the other places where extension_loaded is used for the same thing. Otherwise all the comments about not being able to accurately determine if the extension is available using this method make all the existing tests invalid as well. Or is there something special about gmp that means it can't be tested in the same way as gd, zlib, xlib and mbstring.

Its very confusing because the php documentation says to do it this way https://www.php.net/manual/en/function.extension-loaded.php

@SharkyKZ
Copy link
Contributor

SharkyKZ commented Feb 4, 2021

This PR is fine for what it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants