Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Subform fixes #31567

Merged
merged 9 commits into from
Jun 12, 2021
Merged

[4.0] Subform fixes #31567

merged 9 commits into from
Jun 12, 2021

Conversation

Denitz
Copy link
Contributor

@Denitz Denitz commented Dec 3, 2020

Summary of Changes

Changes in repeatable-table subform layout:

  1. Use correct .table-responsive wrapper.
  2. Use a unique ID for the subform table.
  3. Don't display the field description because it's already displayed as a tooltip in the column header.
  4. Remove the implicit style of width:45% for th.

Common changes:

  1. Don't pass $subForm param by reference in SubformField::loadSubFormData(Form $subForm) because it's an object.
  2. Fix phpdoc in SubformField::setup() for undefined class SimpleXMLElement
  3. Propagate originating field ID into subform layouts via $fieldId
  4. Make SubformField::loadSubFormData protected for possible override.
  5. Fixed actually displayed .control-label.sr-only which still consumed 240px width and broke the table-responsive behavior with screen horizontal scrolling remained.

Testing Instructions

Show multiple subform fields on the same page, use wide forms to require responsive scroller.

Actual result BEFORE applying this Pull Request

Duplicate table IDs, field descriptions below each field, the table is not responsive.

Expected result AFTER applying this Pull Request

Unique table IDs, field descriptions are hidden, the table is responsive.

Documentation Changes Required

No.

@joomla-cms-bot joomla-cms-bot added the NPM Resource Changed This Pull Request can't be tested by Patchtester label Dec 4, 2020
@Denitz
Copy link
Contributor Author

Denitz commented Feb 16, 2021

@Quy no conflicts now

@Quy
Copy link
Contributor

Quy commented Mar 25, 2021

Please fix conflicts.

@RickR2H
Copy link
Member

RickR2H commented Apr 24, 2021

I have tested this item ✅ successfully on 2affe23


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31567.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Jun 10, 2021

I have tested this item ✅ successfully on 2affe23


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31567.

@Quy
Copy link
Contributor

Quy commented Jun 10, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31567.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 10, 2021
@richard67 richard67 added this to the Joomla 4.0 milestone Jun 11, 2021
@richard67 richard67 merged commit 9bd9e52 into joomla:4.0-dev Jun 12, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 12, 2021
@richard67
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants