-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Subform fixes #31567
Merged
Merged
[4.0] Subform fixes #31567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
the
NPM Resource Changed
This Pull Request can't be tested by Patchtester
label
Dec 4, 2020
@Quy no conflicts now |
Please fix conflicts. |
I have tested this item ✅ successfully on 2affe23 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31567. |
1 similar comment
I have tested this item ✅ successfully on 2affe23 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31567. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31567. |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Changes in
repeatable-table
subform layout:.table-responsive
wrapper.width:45%
forth
.Common changes:
$subForm
param by reference inSubformField::loadSubFormData(Form $subForm)
because it's an object.SubformField::setup()
for undefined classSimpleXMLElement
$fieldId
SubformField::loadSubFormData
protected for possible override..control-label.sr-only
which still consumed 240px width and broke the table-responsive behavior with screen horizontal scrolling remained.Testing Instructions
Show multiple subform fields on the same page, use wide forms to require responsive scroller.
Actual result BEFORE applying this Pull Request
Duplicate table IDs, field descriptions below each field, the table is not responsive.
Expected result AFTER applying this Pull Request
Unique table IDs, field descriptions are hidden, the table is responsive.
Documentation Changes Required
No.