Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Rename method arguments to use camelCase casing #31181

Merged
merged 2 commits into from
Nov 3, 2020
Merged

[4.0] Rename method arguments to use camelCase casing #31181

merged 2 commits into from
Nov 3, 2020

Conversation

SharkyKZ
Copy link
Contributor

Partial Pull Request for Issue #30988.

Summary of Changes

Renames some method arguments to use camelCase casing.

Testing Instructions

Thorough code review / Joomla works like before.

Documentation Changes Required

No.

Co-authored-by: Quy <[email protected]>
@Quy
Copy link
Contributor

Quy commented Oct 21, 2020

I have tested this item ✅ successfully on 90e03d1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31181.

@SharkyKZ SharkyKZ added the PHP 8.x PHP 8.x deprecated issues label Oct 23, 2020
@jwaisner
Copy link
Member

jwaisner commented Nov 2, 2020

I have tested this item ✅ successfully on 90e03d1

Tested on clean install. All functionality works as before PR.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31181.

@joomla-cms-bot joomla-cms-bot removed the PHP 8.x PHP 8.x deprecated issues label Nov 2, 2020
@jwaisner
Copy link
Member

jwaisner commented Nov 2, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31181.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 2, 2020
@chmst chmst added this to the Joomla 4.0 milestone Nov 3, 2020
@chmst chmst merged commit 1d47529 into joomla:4.0-dev Nov 3, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 3, 2020
@chmst
Copy link
Contributor

chmst commented Nov 3, 2020

Thanks!

@SharkyKZ SharkyKZ deleted the j4/php8/camelcase-args branch November 3, 2020 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants