-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename method arguments to use camelCase casing (libraries/joomla directory) #31168
Merged
rdeutz
merged 10 commits into
joomla:staging
from
SharkyKZ:j3/php8/camelcase-args-joomla-lib
Oct 27, 2020
Merged
Rename method arguments to use camelCase casing (libraries/joomla directory) #31168
rdeutz
merged 10 commits into
joomla:staging
from
SharkyKZ:j3/php8/camelcase-args-joomla-lib
Oct 27, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quy
reviewed
Oct 22, 2020
I have tested this item ✅ successfully on 7c544d3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31168. |
I have tested this item ✅ successfully on 7c544d3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31168. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31168. |
joomla-cms-bot
added
RTC
This Pull Request is Ready To Commit
and removed
PHP 8.x
PHP 8.x deprecated issues
labels
Oct 24, 2020
nibra
added a commit
to nibra/database
that referenced
this pull request
Dec 15, 2020
nibra
added a commit
to nibra/facebook-api
that referenced
this pull request
Dec 15, 2020
nibra
added a commit
to nibra/session
that referenced
this pull request
Dec 15, 2020
wilsonge
pushed a commit
to joomla-framework/database
that referenced
this pull request
Dec 15, 2020
wilsonge
pushed a commit
to joomla-framework/facebook-api
that referenced
this pull request
Dec 16, 2020
wilsonge
pushed a commit
to joomla-framework/session
that referenced
this pull request
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial Pull Request for Issue #30988.
Summary of Changes
Renames some method arguments to use camelCase casing.
Testing Instructions
Thorough code review / Joomla works like before.
Documentation Changes Required
No.