Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename method arguments to use camelCase casing (libraries/joomla directory) #31168

Merged
merged 10 commits into from
Oct 27, 2020
Merged

Rename method arguments to use camelCase casing (libraries/joomla directory) #31168

merged 10 commits into from
Oct 27, 2020

Conversation

SharkyKZ
Copy link
Contributor

Partial Pull Request for Issue #30988.

Summary of Changes

Renames some method arguments to use camelCase casing.

Testing Instructions

Thorough code review / Joomla works like before.

Documentation Changes Required

No.

@joomla joomla deleted a comment from SharkyKZ Oct 22, 2020
@Quy
Copy link
Contributor

Quy commented Oct 22, 2020

I have tested this item ✅ successfully on 7c544d3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31168.

@SharkyKZ SharkyKZ added the PHP 8.x PHP 8.x deprecated issues label Oct 23, 2020
@alikon
Copy link
Contributor

alikon commented Oct 24, 2020

I have tested this item ✅ successfully on 7c544d3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31168.

@alikon
Copy link
Contributor

alikon commented Oct 24, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31168.

@joomla-cms-bot joomla-cms-bot added RTC This Pull Request is Ready To Commit and removed PHP 8.x PHP 8.x deprecated issues labels Oct 24, 2020
@alikon alikon added the PHP 8.x PHP 8.x deprecated issues label Oct 24, 2020
@rdeutz rdeutz added this to the Joomla 4.0 milestone Oct 27, 2020
@rdeutz rdeutz merged commit 046ee27 into joomla:staging Oct 27, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 27, 2020
@SharkyKZ SharkyKZ deleted the j3/php8/camelcase-args-joomla-lib branch October 27, 2020 13:39
nibra added a commit to nibra/database that referenced this pull request Dec 15, 2020
nibra added a commit to nibra/facebook-api that referenced this pull request Dec 15, 2020
nibra added a commit to nibra/session that referenced this pull request Dec 15, 2020
wilsonge pushed a commit to joomla-framework/database that referenced this pull request Dec 15, 2020
wilsonge pushed a commit to joomla-framework/facebook-api that referenced this pull request Dec 16, 2020
wilsonge pushed a commit to joomla-framework/session that referenced this pull request Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP 8.x PHP 8.x deprecated issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants