-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Small refactor of typehint check in CMSPlugin #30907
Conversation
I have not tested this item. With these tests, can I confirm the PR? This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30907. |
Yes, as long as it's working as before it's fine. |
I have tested this item ✅ successfully on 1f6b0b4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30907. |
I have tested this item ✅ successfully on 1f6b0b4 Hard to find a plugin that the test would either fail for before the test. Harder to find one that would fail for Joomla 4 after the test without writing one. Plugins where parameters are not typehinted I would imagine are unusual? This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30907. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30907. |
Thanks! |
* Refactor typehint check * Make private
Summary of Changes
Follow up to #30581.
Renames poorly named
checkTypeHint()
method and makes it private.Changes it to accept
ReflectionParameter
instead ofReflectionType
to maintain the whole parameter logic inside.Testing Instructions
Test that Joomla and plugins still work.
Documentation Changes Required
No, unless the method was documented somewhere.