Fix feed image

[SharkyKZ]

Once it reaches 4.0, this PR will solve #29236.

Summary of Changes

Fixes feed image display.

Testing Instructions

Create a feed module. Use a feed link containing an image, e.g. http://feeds.bbci.co.uk/news/world/europe/rss.xml.
View the module.

Expected result

Image is shown.

Actual result

Image not shown.

Documentation Changes Required

No.

[toivo]

I have tested this item ✅ successfully on 4de3ebb

Tested successfully in Joomla 3.9.19-dev Nightly Build of 27 May.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29237.}

[conseilgouz]

I have tested this item ✅ successfully on 4de3ebb

Tested this on Joomla 3.9.18

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29237.}

[SharkyKZ]

RTC.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29237.}

[wilsonge]

Thanks!

[wilsonge]

My guess is that this stemmed from the fact this used to be included through CDATA tags https://stackoverflow.com/questions/483675/images-in-rss-feed - we maybe want to handle this case still in 3.x?

[SharkyKZ]

@wilsonge I don't think that's related. This PR concerns main image of the channel, not images of entries. It's created here:

joomla-cms/libraries/src/Feed/Parser/RssParser.php

Lines 135 to 153 in 4314047

	protected function handleImage(Feed $feed, \SimpleXMLElement $el)
	{
	// Create a feed link object for the image.
	$image = new FeedLink(
	(string) $el->url,
	null,
	'logo',
	null,
	(string) $el->title
	);
	// Populate extra fields if they exist.
	$image->link = (string) $el->link;
	$image->description = (string) $el->description;
	$image->height = (string) $el->height;
	$image->width = (string) $el->width;
	$feed->image = $image;
	}