Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Missing language strings #28519

Merged
merged 2 commits into from
Mar 31, 2020
Merged

[4.0] Missing language strings #28519

merged 2 commits into from
Mar 31, 2020

Conversation

astridx
Copy link
Contributor

@astridx astridx commented Mar 31, 2020

Summary of Changes

Add of missing language strings

Testing Instructions

  1. Try to install a manifests with a api section but missing api files. If you like, you can take this zip:
    com_foos.zip
  2. You see this message
    Extensions  Install   test   Administration
  3. Apply this patch and redo the installation with the same manifest.
    You see the same message, but the language string is translated.
    Extensions  Install   test   Administration(1)

Expected result

Actual result

Documentation Changes Required

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Mar 31, 2020
@@ -530,6 +530,7 @@ JLIB_INSTALLER_ABORT_COMP_BUILDADMINMENUS_FAILED="Error building Administrator M
JLIB_INSTALLER_ABORT_COMP_COPY_MANIFEST="Component %1$s: Could not copy PHP manifest file."
JLIB_INSTALLER_ABORT_COMP_COPY_SETUP="Component %1$s: Could not copy setup file."
JLIB_INSTALLER_ABORT_COMP_FAIL_ADMIN_FILES="Component %s: Failed to copy administrator files."
JLIB_INSTALLER_ABORT_COMP_FAIL_API_FILES="Component %s: Failed to copy api files."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
JLIB_INSTALLER_ABORT_COMP_FAIL_API_FILES="Component %s: Failed to copy api files."
JLIB_INSTALLER_ABORT_COMP_FAIL_API_FILES="Component %s: Failed to copy API files."

@@ -530,6 +530,7 @@ JLIB_INSTALLER_ABORT_COMP_BUILDADMINMENUS_FAILED="Error building Administrator M
JLIB_INSTALLER_ABORT_COMP_COPY_MANIFEST="Component %1$s: Could not copy PHP manifest file."
JLIB_INSTALLER_ABORT_COMP_COPY_SETUP="Component %1$s: Could not copy setup file."
JLIB_INSTALLER_ABORT_COMP_FAIL_ADMIN_FILES="Component %s: Failed to copy administrator files."
JLIB_INSTALLER_ABORT_COMP_FAIL_API_FILES="Component %s: Failed to copy api files."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
JLIB_INSTALLER_ABORT_COMP_FAIL_API_FILES="Component %s: Failed to copy api files."
JLIB_INSTALLER_ABORT_COMP_FAIL_API_FILES="Component %s: Failed to copy API files."

@astridx
Copy link
Contributor Author

astridx commented Mar 31, 2020

@brianteeman Thank you. I corrected the string.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 4087b2e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28519.

1 similar comment
@alikon
Copy link
Contributor

alikon commented Mar 31, 2020

I have tested this item ✅ successfully on 4087b2e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28519.

@alikon
Copy link
Contributor

alikon commented Mar 31, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28519.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 31, 2020
@infograf768 infograf768 merged commit 0185f52 into joomla:4.0-dev Mar 31, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 31, 2020
@infograf768
Copy link
Member

tks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants