Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0] Remove padding in system message #28517

Merged
merged 2 commits into from
Mar 31, 2020
Merged

[4.0] Remove padding in system message #28517

merged 2 commits into from
Mar 31, 2020

Conversation

Quy
Copy link
Contributor

@Quy Quy commented Mar 30, 2020

Summary of Changes

Remove extra bottom padding to prevent overlapping the Search field.

Testing Instructions

Run npm i
Go to Content > Articles
Click on the Featured icon
See alert

Expected result

alert-after

Actual result

alert-before

@brianteeman
Copy link
Contributor

To be honest the entire alerts system needs a rewrite

@SharkyKZ
Copy link
Contributor

Make the changes here instead please

https://github.com/joomla/joomla-cms/blob/b4e270ae645c9b5bc7302c7c7ffdd6c91faef728/administrator/templates/atum/scss/vendor/joomla-custom-elements/joomla-alert.scss

@wilsonge wilsonge merged commit dd9676c into joomla:4.0-dev Mar 31, 2020
@wilsonge
Copy link
Contributor

Thanks!

@zero-24 zero-24 added this to the Joomla 4.0 milestone Mar 31, 2020
@Quy Quy deleted the message-padding branch December 1, 2021 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Joomla 4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Quy @brianteeman @SharkyKZ @wilsonge @zero-24 @joomla-cms-bot