Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] convert to prepared statements Viewlevels table #28489

Merged
merged 2 commits into from
Mar 28, 2020
Merged

[4.0] convert to prepared statements Viewlevels table #28489

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8c07c6
sql2prepared
alikon Mar 28, 2020
a3d0148
quote COUNT
alikon Mar 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions libraries/src/Table/ViewLevel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

use Joomla\CMS\Language\Text;
use Joomla\Database\DatabaseDriver;
use Joomla\Database\ParameterType;

/**
* Viewlevels table class.
Expand Down Expand Up @@ -84,13 +85,17 @@ public function check()
return false;
}

$id = (int) $this->id;

// Check for a duplicate title.
$db = $this->_db;
$query = $db->getQuery(true)
->select('COUNT(title)')
->select('COUNT(' . $db->quoteName('title') . ')')
->from($db->quoteName('#__viewlevels'))
->where($db->quoteName('title') . ' = ' . $db->quote($this->title))
->where($db->quoteName('id') . ' != ' . (int) $this->id);
->where($db->quoteName('title') . ' = :title')
->where($db->quoteName('id') . ' != :id')
->bind(':title', $this->title)
->bind(':id', $id, ParameterType::INTEGER);
$db->setQuery($query);

if ($db->loadResult() > 0)
Expand Down