Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] content associations #28488

Merged
merged 1 commit into from
Mar 28, 2020
Merged

Conversation

brianteeman
Copy link
Contributor

Moves the associations button so that it only appears when it can be used ie not on an unsaved article which is the same behaviour as versions and preview.

Moves the associations button so that it only appears when it can be used ie not on an unsaved article which is the same behaviour as versions and preview.
@infograf768
Copy link
Member

If it is done for articles, it should be done for all components concerned.

@brianteeman
Copy link
Contributor Author

brianteeman commented Mar 28, 2020

Agreed.i just wanted to get it tested>confirmed on one first.

@infograf768
Copy link
Member

In fact, it looks like this is the only place where it needs to be modified.

@infograf768
Copy link
Member

I have tested this item ✅ successfully on 2d7e772


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28488.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Mar 28, 2020

I have tested this item ✅ successfully on 2d7e772


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28488.

@Quy
Copy link
Contributor

Quy commented Mar 28, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28488.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 28, 2020
@wilsonge wilsonge merged commit 9a7b6c3 into joomla:4.0-dev Mar 28, 2020
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot added PR-4.0-dev and removed RTC This Pull Request is Ready To Commit labels Mar 28, 2020
@wilsonge wilsonge added this to the Joomla 4.0 milestone Mar 28, 2020
@brianteeman
Copy link
Contributor Author

Thanks

@brianteeman brianteeman deleted the associations branch March 28, 2020 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants