Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] convert to prepared statements User Table #28479

Merged
merged 3 commits into from
Mar 27, 2020
Merged

[4.0] convert to prepared statements User Table #28479

merged 3 commits into from
Mar 27, 2020

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Mar 27, 2020

Summary of Changes

converted sql to prepared statements

Testing Instructions

  • create new users
  • delete users
  • modify users
  • register

Expected result

works as before

Actual result

N/A

@chmst
Copy link
Contributor

chmst commented Mar 27, 2020

I have tested this item ✅ successfully on d1924e9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28479.

1 similar comment
@jwaisner
Copy link
Member

I have tested this item ✅ successfully on d1924e9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28479.

@jwaisner
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28479.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 27, 2020
@Quy
Copy link
Contributor

Quy commented Mar 27, 2020

PHP Notice: Undefined variable: mapGroupId in \libraries\src\Table\User.php on line 398

PHP Warning: count(): Parameter must be an array or an object that implements Countable in \libraries\src\Table\User.php on line 398

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 27, 2020
@alikon
Copy link
Contributor Author

alikon commented Mar 27, 2020

notice/warning fixed

libraries/src/Table/User.php Outdated Show resolved Hide resolved
@Quy
Copy link
Contributor

Quy commented Mar 27, 2020

I have tested this item ✅ successfully on 8268a32


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28479.

@wilsonge wilsonge merged commit f22ed71 into joomla:4.0-dev Mar 27, 2020
@wilsonge
Copy link
Contributor

Thanks!

@wilsonge wilsonge added this to the Joomla 4.0 milestone Mar 27, 2020
@alikon alikon deleted the patch-116 branch March 28, 2020 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants