Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Break up tags code from category interface #28439

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

wilsonge
Copy link
Contributor

@wilsonge wilsonge commented Mar 23, 2020

Pull Request for Issue #24587 .

Summary of Changes

Breaks up tags code from the interface and adds a corresponding trait.

Note as it shares methods with the CategoryServiceTrait we have to choose to prioritize one of the methods (as they are identical I've arbitrarily chosen CategoryServiceTrait but there's no deeper reasoning for that decison)

Testing Instructions

Check the count of items associated with a tag continues to work in the tags component when you filter by a tag type (e.g. article)

Documentation Changes Required

Yup. New tag interface needs to be documented

@wilsonge wilsonge changed the title Break up tags code from category interface [4.0] Break up tags code from category interface Mar 23, 2020
@alikon
Copy link
Contributor

alikon commented Mar 26, 2020

played with tags and article and article category...... lgtm

@alikon
Copy link
Contributor

alikon commented Mar 26, 2020

I have tested this item ✅ successfully on af0ec82


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28439.

1 similar comment
@jwaisner
Copy link
Member

I have tested this item ✅ successfully on af0ec82


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28439.

@jwaisner
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28439.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 26, 2020
@Quy Quy added the PR-4.0-dev label Mar 26, 2020
@wilsonge wilsonge merged commit 38df5ce into joomla:4.0-dev Mar 26, 2020
@wilsonge
Copy link
Contributor Author

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 26, 2020
@wilsonge wilsonge deleted the tags_interface branch March 26, 2020 23:19
@wilsonge wilsonge added this to the Joomla 4.0 milestone Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants