Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Correct implode() argument order #27216

Merged
merged 1 commit into from
Dec 6, 2019
Merged

[4.0] Correct implode() argument order #27216

merged 1 commit into from
Dec 6, 2019

Conversation

SharkyKZ
Copy link
Contributor

@SharkyKZ SharkyKZ commented Dec 6, 2019

Summary of Changes

Changes implode() argument order to solve deprecation messages in PHP 7.4:

Deprecated: implode(): Passing glue string after array is deprecated.

Testing Instructions

Code review.

Documentation Changes Required

No.

@ChristineWk
Copy link

I have tested this item ✅ successfully on b905df2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27216.

@HLeithner
Copy link
Member

Wow php 4 wants it syntax back, thanks for fixing this.

@HLeithner HLeithner merged commit 45c42cd into joomla:4.0-dev Dec 6, 2019
@HLeithner HLeithner added this to the Joomla 4.0 milestone Dec 6, 2019
@SharkyKZ SharkyKZ deleted the j4/php74/implode branch December 6, 2019 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants