Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[com_categories] - convert to prepared statement #27205

Merged
merged 25 commits into from
Jan 6, 2020
Merged

[com_categories] - convert to prepared statement #27205

merged 25 commits into from
Jan 6, 2020

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Dec 3, 2019

Summary of Changes

use prepared statement for SQL

Testing Instructions

test com_categories

Expected result

works as before

Actual result

N/A

@alikon alikon marked this pull request as ready for review December 3, 2019 19:08
@alikon alikon changed the title [wip][com_categories] - convert to prepared statement [com_categories] - convert to prepared statement Dec 3, 2019
@Quy
Copy link
Contributor

Quy commented Dec 3, 2019

mysqli_stmt::bind_param(): Number of variables doesn't match number of parameters in prepared statement in \libraries\vendor\joomla\database\src\Mysqli\MysqliStatement.php on line 430

Edit a category but unable to save.

@alikon
Copy link
Contributor Author

alikon commented Dec 4, 2019

that i could be burned on 🔥
😄
on postgresql a save/new category works
on pdo mysql, don't, like has been correctly reported
😱
the earth is becoming to be flat ....

@Quy
Copy link
Contributor

Quy commented Dec 10, 2019

I have tested this item ✅ successfully on 8ad3883

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27205.

SharkyKZ
SharkyKZ reviewed Dec 12, 2019
View reviewed changes
administrator/components/com_categories/Field/CategoryeditField.php
@@ -332,10 +345,25 @@ protected function getOptions()
}
}

if (($this->element['parent'] == true || $jinput->get('option') == 'com_categories')
&& (isset($row) && !isset($options[0]))
if ($oldCat != 0 && ($this->element['parent'] == true || $jinput->get('option') == 'com_categories')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the changes here and to the query below?

@jwaisner
Copy link
Member

jwaisner commented Jan 4, 2020

I have tested this item ✅ successfully on 8ad3883

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27205.

@SharkyKZ
Copy link
Contributor

SharkyKZ commented Jan 6, 2020

RTC.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27205.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 6, 2020
@HLeithner HLeithner merged commit 1557ec2 into joomla:4.0-dev Jan 6, 2020
@HLeithner
Copy link
Member

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 6, 2020
@HLeithner HLeithner added this to the Joomla 4.0 milestone Jan 6, 2020
@alikon alikon deleted the patch-125 branch January 7, 2020 07:47
brianteeman pushed a commit to brianteeman/joomla-cms that referenced this pull request Feb 4, 2020
@alikon @brianteeman
[com_categories] - convert to prepared statement (joomla#27205)
3e8b13d 
Co-authored-by: Quy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SharkyKZ SharkyKZ SharkyKZ left review comments

@Quy Quy Quy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Joomla 4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@alikon @Quy @jwaisner @SharkyKZ @HLeithner @joomla-cms-bot