[4.0] Multilingual status module improvements

[infograf768]

Replaces #24062 which had conflicts

This PR adds a Notice and displays the language concerned when the Content Language for that language has been deleted and remains in the site an orphan home page while the site language is published.
It also adds a Notice when a Content Language is in the trash.

It also reinstate all states of a content language to display the correct icons.
published = 1
published = 0
published = -2 (i.e. trash) and for this one displays the trash icon

It also modifies all the queries in the Helper to use quotename()

See more below

Testing Instructions

Install a multilingual site with all languages available to install
French fr-FR
German de-DE
Persian fa-IR

Then use the Cpanel Multilingual Sample Data module to create a basic.

First test:
Display the Content languages Manager
Trash AND delete the fa-IR Persian content language.

You should get this when displaying the multilingual status module

Then unpublish the French fr-FR Content Language.
And trash (do NOT delete) the German de-DE Content language.
I.e. Manager should look like this

You should get this when displaying the multilingual status module

Unpublish also the fr-FR Home page to get a new notice.
Deleted Content Language error now displays the notice as last.
see #24062 (comment)

Added new Notice when both Content Language and Home page are unpublished.
We should now get in that case:

Added notice when both content language and home page missing. added trash icon when home page is in the trash.

Added warning icon when home page does not exist.

Reminder

It is OK to have an Unpublished Content Language (as French is above) as it lets the site owner prepare a new Language for the multilingual site.

The screenshots were taken in March. They will now rather look like this:

@Quy
@alikon
Please test and specially look at the queries as I did my best but there could be improvements there.

[infograf768]

@Quy
Also did other combined queries, as much as I could do.
Could be missing some in the getStatus() method but I honestly think it would make the queries there more confusing than benefiting as we have multiple select.
Also I am not aware if we need or not to also change line 130 join and if we do as on line 123, if we should keep the ' AND ' as is.

May I suggest now to test the results of this PR rather than concentrating on the queries format as that type of format is absent from the majority of 4.0 code.

[infograf768]

Done.

[Quy]

These are redundant.

The de-DE Content Language is trashed. It will not display on the site.

The Content Language de-DE is trashed.

[infograf768]

These are redundant.

Good find! Corrected.

[infograf768]

Added a new Error when the Default Site Language has no published Content Language.
As this would totally break the site, It is displayed as an Error on top of other warnings.
To test, unpublish, trash or delete the Content Language related to the Site Default Language.
You should get this:

The second part of the new message "If not corrected, the multilingual feature will not work!"
could be improved. Proposals welcome!

[infograf768]

Changed new string to
COM_LANGUAGES_MULTILANGSTATUS_ERROR_DEFAULT_CONTENT_LANGUAGE="The Content Language for the <strong>%s</strong> default Site Language is unpublished or does not exist. <strong>If not corrected, the multilingual feature may not function properly or the site may not be reachable!</strong>"

Thanks Mig.

I guess it is now ready to go, as a module.

[imanickam]

I have tested this item ✅ successfully on 605b87e

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27184.}

[Quy]

I have tested this item ✅ successfully on 0cc3ab8

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27184.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27184.}

[HLeithner]

Thanks

[infograf768]

@brianteeman
I can make a new patch implementing what you wanted, with return when Close to the place where the Multilingual status was clicked.

Is that what you want?

[brianteeman]

That is almost what I was talking about - give me one sec

[brianteeman]

The url would be
index.php?option=com_languages&view=multilangstatus&return=xxxxxxxxxxx

without the template=component so that it looks to be part of the site

[infograf768]

I will let you do it. I found some issues here doing it like this when switching to other menus without closing first the multilingual status module.

EDIT: also it lets click again on the module icon and we get into an endless loop as the redirect would now be the multilangstatus module path itself.

[infograf768]

In any case the return is obtained by
$redirect = Uri::getInstance()->toString(); in the module default.php

[brianteeman]

ok - I will put it on my todo