Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] [plg_sampledata_multilang] Add missing checks #27183

Merged
merged 4 commits into from
Dec 3, 2019
Merged

[4.0] [plg_sampledata_multilang] Add missing checks #27183

merged 4 commits into from
Dec 3, 2019

Conversation

SharkyKZ
Copy link
Contributor

@SharkyKZ SharkyKZ commented Nov 29, 2019

Pull Request for Issue # .

Summary of Changes

Adds context check in last step. Fixes weird alert when installing Testing Sample Data.

Testing Instructions

  1. On monolingual site install Testing Sample Data. Inspect progress messages.
  2. On multilingual site install Multilingual Sample Data. Inspect progress messages.

Expected result

  1. Messages appear normally.
  2. Works like before.

Actual result

  1. Empty space appears between step 7 and step 8 messages.

Documentation Changes Required

No.

@SharkyKZ SharkyKZ mentioned this pull request Nov 29, 2019
13 tasks
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on e3ebc69


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27183.

@Quy Quy added the PR-4.0-dev label Nov 30, 2019
@infograf768
Copy link
Member

@SharkyKZ
If checking session is necessary for this plugin concerning the last Step, then it is also necessary for blog sample data as we only have there

	public function onAjaxSampledataApplyStep4()
	{
		if ($this->app->input->get('type') != $this->_name)
		{
			return;
		}

I suggest to also correct that one in this PR.

@SharkyKZ
Copy link
Contributor Author

SharkyKZ commented Dec 1, 2019

Not really necessary in the last step.

@infograf768
Copy link
Member

I have tested this item ✅ successfully on a03ac6e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27183.

@Quy
Copy link
Contributor

Quy commented Dec 1, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27183.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 1, 2019
@wilsonge wilsonge merged commit 75379e6 into joomla:4.0-dev Dec 3, 2019
@wilsonge
Copy link
Contributor

wilsonge commented Dec 3, 2019

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 3, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Dec 3, 2019
@SharkyKZ SharkyKZ deleted the j4/plg_sampledata_multilang branch December 3, 2019 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants