iFrameHeight() needs to be called with a reference to the iframe-object #25038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems right to me. @brianteeman as author of #19136 : Could you check? |
|
Sorry but without any explanation or description in the post I don't waste my time |
|
@tkempf please write explanation or description like @brianteeman wrote above. |
|
Sorry for that, i updated description now. |
|
I have tested this item ✅ successfully on b0361f6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25038. |
1 similar comment
|
I have tested this item ✅ successfully on b0361f6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25038. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25038. |
|
thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since #19136
Pull Request for Issue # .
Summary of Changes
iFrameHeight() needs to be called with a reference to the iframe-object as declared in
media/com_wrapper/js/iframe-height.js
Testing Instructions
Create Menu-Item with type wrapper, set extended properties of menu-item to auto-size
Expected result
Iframe should adapt it's size to the content height of it's document
Actual result
size does not change
Documentation Changes Required