-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix timestamp format for track_date (banner) #24651
Conversation
I only need opcache_invalidate function to solve issue joomla#21943
We have #24652. |
Reopened because the PR #24652 adds a new row for each banner track at anytime. |
@HLeithner , for review please. |
I have tested this item ✅ successfully on 5404d21 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24651. |
This unfortunately is the wrong way to fix this. We still need to format this with ->toSQL(), since the used format() might not be the right format for the RDBMS. So you would have to modify the trackdate or create a helper trackdate which you can then format with ->toSQL. |
@Hackwar , is that what you expect ? |
I expected something along the lines of ->setMinutes(0) or something like that, but I think date objects are immutable... So it isn't really a nice solution, but should work... |
I have tested this item ✅ successfully on 43ebd61 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24651. |
@Pinkeltje please test again. |
RTC ? |
I have tested this item ✅ successfully on ba41eaa This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24651. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24651. |
Merging here thanks for the patience |
Pull Request for Issue #24649.
Summary of Changes
Timestamp format.
Testing Instructions
Added Instructions from #24649 (comment) by @franz-wohlkoenig: