Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timestamp format for track_date (banner) #24651

Merged
merged 20 commits into from
Mar 17, 2022
Merged

Conversation

twister65
Copy link
Contributor

@twister65 twister65 commented Apr 21, 2019

Pull Request for Issue #24649.

Summary of Changes

Timestamp format.

Testing Instructions

Added Instructions from #24649 (comment) by @franz-wohlkoenig:

  • Install Joomla with examples. The database must be postgreSQL.
  • Go to Components->Banners->Banners.
  • Click Support Joomla! banner.
  • Click the Banner Details tab.
  • Select Yes for "Track Impressions" and "Track Clicks".
  • Go to the example site: index.php/using-joomla/extensions/modules/display-modules/banner

@twister65
Copy link
Contributor Author

We have #24652.

@twister65 twister65 closed this Apr 21, 2019
@twister65 twister65 deleted the banner branch April 21, 2019 09:58
@twister65 twister65 restored the banner branch April 22, 2019 14:47
@twister65
Copy link
Contributor Author

Reopened because the PR #24652 adds a new row for each banner track at anytime.
The counter is always 1.
We want to add a new row every hour and increment the counter.

@twister65
Copy link
Contributor Author

@HLeithner , for review please.
See #24652 (comment)

@Pinkeltje
Copy link

I have tested this item ✅ successfully on 5404d21


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24651.

@Hackwar
Copy link
Member

Hackwar commented Aug 23, 2019

This unfortunately is the wrong way to fix this. We still need to format this with ->toSQL(), since the used format() might not be the right format for the RDBMS. So you would have to modify the trackdate or create a helper trackdate which you can then format with ->toSQL.

@twister65
Copy link
Contributor Author

@Hackwar , is that what you expect ?

@Hackwar
Copy link
Member

Hackwar commented Aug 24, 2019

I expected something along the lines of ->setMinutes(0) or something like that, but I think date objects are immutable... So it isn't really a nice solution, but should work...

@SharkyKZ
Copy link
Contributor

SharkyKZ commented Dec 9, 2019

I have tested this item ✅ successfully on 43ebd61


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24651.

@SharkyKZ
Copy link
Contributor

SharkyKZ commented Dec 9, 2019

@Pinkeltje please test again.

@twister65
Copy link
Contributor Author

RTC ?

@Quy
Copy link
Contributor

Quy commented Feb 6, 2022

I have tested this item ✅ successfully on ba41eaa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24651.

@Quy Quy removed the JBS label Feb 6, 2022
@Quy
Copy link
Contributor

Quy commented Feb 6, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24651.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 6, 2022
@zero-24 zero-24 added this to the Joomla 3.10.7 milestone Mar 17, 2022
@zero-24 zero-24 merged commit fff593a into joomla:3.10-dev Mar 17, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 17, 2022
@zero-24
Copy link
Contributor

zero-24 commented Mar 17, 2022

Merging here thanks for the patience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants