Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.9] Backport jQuery Security Fix #24533

Merged
merged 3 commits into from
Apr 9, 2019

Conversation

SniperSister
Copy link
Contributor

Summary of Changes

This PR backports a security-relevant fix in JQuery, see jquery/jquery#4333

As the original issue and the fix are public anyway, JSST decided to do a public PR to allow more testers to look at the patch.

Testing Instructions

  1. Apply patch, open browser console, browser Joomla front- and backend and make sure no errors are shown with debug mode enabled and disabled

@SniperSister
Copy link
Contributor Author

/cc @joomla/security

@ghost ghost added the J3 Issue label Apr 9, 2019
@brianteeman
Copy link
Contributor

just a small thing but its probably good practice to add a comment to the copyright header -you can use the comment you placed inline

@SniperSister
Copy link
Contributor Author

@brianteeman done!

@brianteeman
Copy link
Contributor

thanks

@HLeithner HLeithner merged commit 125896d into joomla:staging Apr 9, 2019
@HLeithner
Copy link
Member

thx

@HLeithner HLeithner added this to the Joomla 3.9.5 milestone Apr 9, 2019
@SniperSister SniperSister deleted the 39-jquerypatch2 branch May 5, 2019 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants