Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Fix multilang module #24341

Closed
wants to merge 3 commits into from
Closed

Conversation

Bakual
Copy link
Contributor

@Bakual Bakual commented Mar 25, 2019

Pull Request for Issue #24339

Summary of Changes

  • Remove hardcoded reference to mod_multilangstatus in mod_status
  • Remove no longer used helper class in mod_multilangstatus

Bringing the behavior back to a regular module.

Testing Instructions (before PR)

First Scenario when language filter plugin is disabled:

  • Try to enable the multilanguage status module and assign it to a position (eg "status")
  • Notice the not so nice appearance of the icon
  • Refresh page
  • Module icon gone again

Second scenario when language filter plugin is enabled:

  • If you did the first scenario, you now have two multilang icons
  • Try to disable the multilanguage status module in the module manager
  • First icon vanished, second one still visible
  • Refresh page
  • Both icons visible again. Module published again in the manager

Expected result

Bevahior like any other module

Actual result

Prior to PR: It seems to be living and doing its own thing 😨

After PR: Regular behavior:

  • If module is assigned to a position and published -> appears.
  • If module is not assigned to a position and/or not published -> doesn't appear.

Documentation Changes Required

None

@infograf768
Copy link
Member

See #24339

@C-Lodder

@C-Lodder
Copy link
Member

I've read the comments

@ghost ghost added the J4 Issue label Apr 5, 2019
@ghost ghost removed the J4 Issue label Apr 13, 2019
@brianteeman
Copy link
Contributor

@Bakual Assuming that I am reading this correctly this PR is no longer relevant. I am closing it at this time. If I am mistaken you can always re-open it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants