Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Fix double query for multilingualstatus module #21906

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

infograf768
Copy link
Member

@infograf768 infograf768 commented Aug 29, 2018

Redo of #21894

Summary of Changes

Prevents double query. Issue found by @brianteeman

Testing Instructions

Set debug on.

Make sure the multilingual status module is set to published or unpublished depending on the settings of the languagefilter plugin before and after patch.

After patch

No more double query

@ghost
Copy link

ghost commented Aug 29, 2018

I have tested this item ✅ successfully on 109462e

Without PR found "mod_multilangstatus" 8 Times, with PR found 6 Times.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21906.

@brianteeman
Copy link
Contributor

brianteeman commented Aug 29, 2018

@franz-wohlkoenig what page were you on and are you sure it was the same query

@ghost
Copy link

ghost commented Aug 29, 2018

what page were you on

/index.php?option=com_modules Modules (Administrator)

are you sure it was the same query

no, i'm not sure. I test as i understand Instructions. So to be sure i set Test back as "not tested".

@ghost
Copy link

ghost commented Aug 29, 2018

I have not tested this item.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21906.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 109462e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21906.

@ghost
Copy link

ghost commented Aug 29, 2018

I have tested this item ✅ successfully on 109462e

Test by Help of @infograf768 on Glip, thanks again.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21906.

@ghost
Copy link

ghost commented Aug 29, 2018

Ready to Commit after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 29, 2018
@wilsonge wilsonge merged commit 8281b0a into joomla:4.0-dev Aug 29, 2018
@joomla-cms-bot joomla-cms-bot added PR-4.0-dev and removed RTC This Pull Request is Ready To Commit labels Aug 29, 2018
@wilsonge wilsonge added this to the Joomla 4.0 milestone Aug 29, 2018
@infograf768 infograf768 deleted the 4.0-multilingualstatusquery branch August 30, 2018 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants