[4.0] [RFC] Optimize countItems and introduce component name #21667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the follow up PR of #21641 discussion. |
|
I like the move of the countItems function. But the name attribute looks for me somehow not right. I would do in the trait a function like getWorkfloowExtensionNameand which returns the name per default out of the classname. If a component does something special, then there is a possibility to override it. Just an idea. |
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests removes the countItems() function from contentComponent (will also be done for other components). As part of this PR a now Component variable is introduced because its not possible to detect the current component name in a ServiceTrait.
Now I would like to know if there is a better way to do this.
Summary of Changes
Removed ContentComponent::countItems
Update CategoriesServicesTrait::countItems to support WorkflowServiceInterface
Added $name variable to all "services" components
Testing Instructions
Test components using categories specially the numbers per publish state in the category overview.
Expected result
Works
Actual result
Should work