[4.0] Change com_fields to services #21420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsonge
reviewed
Aug 8, 2018
| * @license GNU General Public License version 2 or later; see LICENSE.txt | ||
| */ | ||
|
|
||
| namespace Joomla\Component\Fields\Site\Dispatcher; |
There was a problem hiding this comment.
Given this is documented as basically the public API to the component, should we move this to the libraries folder? https://docs.joomla.org/J3.x:Adding_custom_fields/Implement_into_your_component#Public_helper_classes_and_API
Genuinely not sure if it's a good or bad idea - but I guess if we're namespacing it nows the time to do it if we're going to....
There was a problem hiding this comment.
It uses models from com_fields so I would not move stuff to libraries with a dependency to an extension (I know we did that in the past).
…ices/fields # Conflicts: # administrator/components/com_content/Model/ArticleModel.php
|
Sorry can you fix the conflicts here and I'll merge this |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves com_fields to the service based extension setup.
See #20217 for details.