Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Fix: Associations tab should display only one Notice when item edited is set to ALL languages #21281

Closed
wants to merge 3 commits into from

Conversation

infograf768
Copy link
Member

@infograf768 infograf768 commented Jul 28, 2018

Pull Request for Issue #20575

Summary of Changes

Modified js to get a unique Notice.

Testing Instructions

Create a multingual site with 3 languages.
Create an article (or any item) with language set to ALL.
save (NOT save and close)
Display the associations tab

Before patch

screen shot 2018-07-28 at 11 31 07

After patch

screen shot 2018-07-28 at 11 29 19

@dgrammatiko @chmst

@ghost
Copy link

ghost commented Jul 28, 2018

I have tested this item ✅ successfully on 8b8346b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21281.

@infograf768
Copy link
Member Author

I will have to do a new PR for that. But It looks like it's hard to test as I have some issues with core 4.0

@joomla-cms-bot
Copy link

Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/21281

@ghost
Copy link

ghost commented Aug 2, 2018

closed in favor of #21362


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21281.

@infograf768 infograf768 deleted the 4.0-assoc_tab_notices branch August 2, 2018 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants