Create custom admin article menus #20890

brianteeman · 2018-06-27T10:47:22Z

See #20233 for detailed explanation of the use case

Test Instructions

Create and enable an admin menu with the "Joomla preset"

Create a new admin menu item of type article list and you can see you now have a full set of filters that you can apply.

For example you can now create menu items in the admin to each category.

If approved I will create the same option for other components

This does not resolve everything on #20233 as it still needs field categories to be implemented for that

Thanks to @tonypartridge for his help

See joomla#20233 for detailed explanation of the use case ### Test Instructions Create and enable an admin menu with the "Joomla preset" Create a new admin menu item of type article list and you can see you now have a full set of filters that you can apply. For example you can now create menu items in the admin to each category. If approved I will create the same option for other components This does not resolve everything on joomla#20233 as it still needs field categories to be implemented for that

tonypartridge · 2018-06-27T10:54:44Z

love it, will give it a test soon 👌

Quy · 2018-06-27T12:47:53Z

administrator/components/com_content/views/articles/tmpl/default.xml

+				name="filter_language"
+				type="contentlanguage"
+				label="COM_MENUS_ADMIN_LANGUAGE_LABEL"
+				description="COM_MENUS_ADMIN_LANGUAGE_LABEL"


Change to COM_MENUS_ADMIN_LANGUAGE_DESC

Quy · 2018-06-27T12:48:13Z

administrator/language/en-GB/en-GB.com_menus.ini

@@ -9,6 +9,18 @@ COM_MENUS_ACTION_DESELECT="Deselect"
 COM_MENUS_ACTION_EXPAND="Expand"
 COM_MENUS_ACTION_SELECT="Select"
 COM_MENUS_ADD_MENU_MODULE="Add a module for this menu"
+COM_MENUS_ADMIN_AUTHOR_DESC="Filter by author."
+COM_MENUS_ADMIN_AUTHOR_LABEL="Author"
+COM_MENUS_ADMIN_CATEGORY_DESC="Filter by Category"


Lowercase C and add a period.

carlitorweb · 2018-06-27T13:04:59Z

Can add filters to the new fields, or in this case is not necessary? following what doing in others PRs

brianteeman · 2018-06-27T13:22:29Z

Sorry I don't understand

carlitorweb · 2018-06-27T13:23:53Z

administrator/components/com_content/views/articles/tmpl/default.xml

+			</field>			
+
+			<field
+				name="filter_tag"


for example, add to this field the filter="int_array"

tonypartridge · 2018-06-27T13:24:38Z

No, all this is doing is pre-setting the filters that already exit on a page.

…

On 27 Jun 2018, 14:05 +0100, Carlos Rodriguez ***@***.***>, wrote: Can we add filters to the new fields, or in this case is not necessary? following what doing in others PRs — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

mbabker · 2018-06-27T13:27:59Z

He's talking about input filters (essentially JFactory::getApplication()->input->get('foo', 'default', $filter);, not the UI filters.

tonypartridge · 2018-06-27T13:30:29Z

Then of course it is possible as we are just passing the request variables. But in doing that, you have no control over the filters on that page if you pass them in and they work. Note, I haven’t tried filtering the admin ui with filters not existent on the UI. But wouldn’t really advise it.

…

On 27 Jun 2018, 14:28 +0100, Michael Babker ***@***.***>, wrote: He's talking about input filters (essentially JFactory::getApplication()->input->get('foo', 'default', $filter);, not the UI filters. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

mbabker · 2018-06-27T13:35:33Z

You're still missing the point here I'm afraid.

The filter="whatever" attribute sets what data type something is filtered/validated as when it is read from the request in the JForm API when filtering/validating data. So if you set filter="int" on a field, then when the field's data is read from the request it is filtered/validated as an integer.

tonypartridge · 2018-06-27T13:36:49Z

Ah, clearly I missed that. I just saw the filter on custom fields.

…

On 27 Jun 2018, 14:35 +0100, Michael Babker ***@***.***>, wrote: You're still missing the point here I'm afraid. The filter="whatever" attribute sets what data type something is filtered/validated as when it is read from the request in the JForm API when filtering/validating data. So if you set filter="int" on a field, then when the field's data is read from the request it is filtered/validated as an integer. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

carlitorweb · 2018-06-27T13:37:46Z

@tonypartridge Sorry for no explain well when i ask about this. Thank you @mbabker

brianteeman · 2018-06-27T13:47:28Z

Gotya. Will update.

brianteeman · 2018-06-27T14:19:37Z

@SharkyKZ can you check the filters please

carlitorweb · 2018-06-27T14:34:38Z

When you create an admin menu item to display a list of all articles there is no option to select a filter so the article list displays all the articles.

So, this is well covered in this PR. Except, not for the Statue and Access levels. Also, will be good do the same with the featured articles view

brianteeman · 2018-06-27T14:38:37Z

I did think about status and access but there is no point. A users ACL addresses the access and I don't want to pre-filter on status - thats not a good idea.

As for the featured view thats a special type of thing and it doesnt match the use case for this - my 2c

carlitorweb · 2018-06-27T14:49:37Z

Roger that. So, this work perfect!

carlitorweb · 2018-06-27T14:50:44Z

I have tested this item ✅ successfully on 921f0e1

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20890.}

SharkyKZ · 2018-06-27T14:52:07Z

Filters OK.

tonypartridge · 2018-06-28T00:29:45Z

I actually think the access level could be handy for when filtering lots of articles assigned to certain access levels, i.e. ‘Guest Articles’, ‘Members Articles’. ? Just a thought

…

On 27 Jun 2018, 15:38 +0100, Brian Teeman ***@***.***>, wrote: I did think about status and access but there is no point. A users ACL addresses the access and I don't want to pre-filter on status - thats not a good idea. As for the featured view > If approved I will create the same option for other components — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

brianteeman · 2018-06-28T09:10:42Z

@tonypartridge ah - I was thinking of ACL and not access levels - i will add it

carlitorweb · 2018-07-06T13:42:47Z

I have tested this item ✅ successfully on 8284fd0

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20890.}

Quy · 2018-07-06T14:49:18Z

administrator/components/com_content/views/articles/tmpl/default.xml

+				filter="int_array"
+				>
+				<option value="0">JNONE</option>
+			</field>			


Remove trailing tabs

Quy · 2018-07-06T15:01:00Z

administrator/components/com_content/views/articles/tmpl/default.xml

+				description="COM_MENUS_ADMIN_ACCESS_DESC"
+				multiple="true"
+				filter="int_array"
+			/>	


Remove trailing tab

Quy · 2018-07-06T15:25:08Z

I have tested this item ✅ successfully on aa76e5b

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20890.}

Quy · 2018-07-06T15:26:11Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20890.}

brianteeman · 2018-07-07T16:51:30Z

Thanks for merging. I will add the same for other components now.

helpwise · 2018-08-30T04:44:22Z

Thanks for this effort Brian et al,.. to make this thing really sing, is it possible to add 'Category Template Layout' selector to the new category menu item ?

The Category Menu already has 'template selector', but it only works on single articles and not the category list/blog files (because the list/blog is inherently the category template via an XML file ).
#19613

Perhaps create a new menu item called "Category (templateable)" so all the old stuff is compatible, and then allow it to properly override both the category and article layouts.. ?

ghost · 2018-08-30T05:13:17Z

@helpwise can you please open a new Issue (and Link to this PR) as Comments on closed Issues didn't get much Notice?

helpwise · 2018-08-30T05:22:20Z

Oh - yes - sorry! :)

joomla-cms-bot added Language Change This is for Translators PR-staging labels Jun 27, 2018

Quy reviewed Jun 27, 2018

View reviewed changes

brianteeman added 2 commits June 27, 2018 13:56

Update default.xml

112dcac

Update en-GB.com_menus.ini

da32fab

carlitorweb reviewed Jun 27, 2018

View reviewed changes

add filters

921f0e1

add viewing access level

8284fd0

Quy reviewed Jul 6, 2018

View reviewed changes

brianteeman added 2 commits July 6, 2018 16:01

Update default.xml

935521a

Update default.xml

aa76e5b

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 6, 2018

mbabker changed the base branch from staging to 3.9-dev July 7, 2018 16:32

mbabker added PR-3.9-dev and removed PR-staging labels Jul 7, 2018

mbabker added this to the Joomla 3.9.0 milestone Jul 7, 2018

mbabker merged commit 3ddbac5 into joomla:3.9-dev Jul 7, 2018

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 7, 2018

brianteeman deleted the custom_admin_menu branch July 7, 2018 16:51

zero-24 mentioned this pull request Aug 29, 2018

[3.9] Create custom admin article menus joomlagerman/joomla#454

Closed

jwaisner mentioned this pull request Mar 11, 2020

Improve admin menu items #17407

Closed

brianteeman mentioned this pull request Jan 15, 2023

[5.x] Menu Listfilters #39634

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create custom admin article menus #20890

Create custom admin article menus #20890

brianteeman commented Jun 27, 2018 •

edited by joomla-cms-bot

Loading

tonypartridge commented Jun 27, 2018

Quy Jun 27, 2018

Quy Jun 27, 2018 •

edited

Loading

carlitorweb commented Jun 27, 2018 •

edited

Loading

brianteeman commented Jun 27, 2018

carlitorweb Jun 27, 2018

tonypartridge commented Jun 27, 2018 via email

mbabker commented Jun 27, 2018

tonypartridge commented Jun 27, 2018 via email

mbabker commented Jun 27, 2018

tonypartridge commented Jun 27, 2018 via email

carlitorweb commented Jun 27, 2018

brianteeman commented Jun 27, 2018

brianteeman commented Jun 27, 2018

carlitorweb commented Jun 27, 2018

brianteeman commented Jun 27, 2018 •

edited

Loading

carlitorweb commented Jun 27, 2018

carlitorweb commented Jun 27, 2018

SharkyKZ commented Jun 27, 2018

tonypartridge commented Jun 28, 2018 via email

brianteeman commented Jun 28, 2018

carlitorweb commented Jul 6, 2018

Quy Jul 6, 2018 •

edited

Loading

Quy Jul 6, 2018

Quy commented Jul 6, 2018

Quy commented Jul 6, 2018

brianteeman commented Jul 7, 2018

helpwise commented Aug 30, 2018 •

edited

Loading

ghost commented Aug 30, 2018

helpwise commented Aug 30, 2018

Create custom admin article menus #20890

Create custom admin article menus #20890

Conversation

brianteeman commented Jun 27, 2018 • edited by joomla-cms-bot Loading

Test Instructions

tonypartridge commented Jun 27, 2018

Quy Jun 27, 2018

Choose a reason for hiding this comment

Quy Jun 27, 2018 • edited Loading

Choose a reason for hiding this comment

carlitorweb commented Jun 27, 2018 • edited Loading

brianteeman commented Jun 27, 2018

carlitorweb Jun 27, 2018

Choose a reason for hiding this comment

tonypartridge commented Jun 27, 2018 via email

mbabker commented Jun 27, 2018

tonypartridge commented Jun 27, 2018 via email

mbabker commented Jun 27, 2018

tonypartridge commented Jun 27, 2018 via email

carlitorweb commented Jun 27, 2018

brianteeman commented Jun 27, 2018

brianteeman commented Jun 27, 2018

carlitorweb commented Jun 27, 2018

brianteeman commented Jun 27, 2018 • edited Loading

carlitorweb commented Jun 27, 2018

carlitorweb commented Jun 27, 2018

SharkyKZ commented Jun 27, 2018

tonypartridge commented Jun 28, 2018 via email

brianteeman commented Jun 28, 2018

carlitorweb commented Jul 6, 2018

Quy Jul 6, 2018 • edited Loading

Choose a reason for hiding this comment

Quy Jul 6, 2018

Choose a reason for hiding this comment

Quy commented Jul 6, 2018

Quy commented Jul 6, 2018

brianteeman commented Jul 7, 2018

helpwise commented Aug 30, 2018 • edited Loading

ghost commented Aug 30, 2018

helpwise commented Aug 30, 2018

brianteeman commented Jun 27, 2018 •

edited by joomla-cms-bot

Loading

Quy Jun 27, 2018 •

edited

Loading

carlitorweb commented Jun 27, 2018 •

edited

Loading

brianteeman commented Jun 27, 2018 •

edited

Loading

Quy Jul 6, 2018 •

edited

Loading

helpwise commented Aug 30, 2018 •

edited

Loading