Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Migrate com_menus to services #20704

Merged
merged 14 commits into from
Jun 20, 2018

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Jun 9, 2018

Pull Request for Issue #20487.

Moves com_menus to the service based extension setup. Additionally it makes extensions work which do route their views completely to the back end.

See #20217 for details.

@infograf768
Copy link
Member

Very hard to test this as git apply does not work with it.
After trying some stuff (renaming and moving some files, I do get
`0 Class 'Joomla\Component\Menus\Administrator\Helper\JTable' not found' when selecting menu items associations in com_associations

Not sure this is related to the PR as I may have been wrong in applying the patch

@infograf768
Copy link
Member

Looks also like we still have a call to MenusHtml line 248 of /administrator/components/com_menus/tmpl/items/default.php
it should be
<?php echo JHtml::_('menus.association', $item->id); ?>

@zero-24
Copy link
Contributor

zero-24 commented Jun 11, 2018

Can you please update the since tags to deploy Version?

@laoneo
Copy link
Member Author

laoneo commented Jun 15, 2018

@infograf768 fixed the issues.

@infograf768
Copy link
Member

@laoneo
git apply still does not work with this PR.
As it is quite a job to apply this patch with eclipse (it does not rename and move files around and does not create new folders), could you give a link to your branch for us to download, install and test? I could not find the Digital-Peak:j4/service/menus branch.

@laoneo
Copy link
Member Author

laoneo commented Jun 16, 2018

@infograf768
Copy link
Member

I do not have the errors I remarked before. Menu items associations look like working fine too.

@laoneo
Copy link
Member Author

laoneo commented Jun 16, 2018

So can we mark it as successful?

@infograf768
Copy link
Member

I have tested this item ✅ successfully on e5eb507


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20704.

@wilsonge wilsonge merged commit fc5c012 into joomla:4.0-dev Jun 20, 2018
@wilsonge wilsonge deleted the j4/service/menus branch June 20, 2018 16:26
@wilsonge wilsonge added this to the Joomla 4.0 milestone Jun 20, 2018
@wilsonge
Copy link
Contributor

Nice one! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants