-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Plugin as services #20547
Merged
Merged
[4.0] Plugin as services #20547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nents/service/dispatcher # Conflicts: # libraries/src/Application/CMSApplication.php # libraries/src/Application/CMSApplicationInterface.php # libraries/src/Application/CliApplication.php # libraries/src/Application/ConsoleApplication.php # libraries/src/Categories/Categories.php # libraries/src/MVC/Model/BaseDatabaseModel.php
…e/services # Conflicts: # libraries/src/Extension/ExtensionManagerTrait.php
… j5/plugin/services
…e/services # Conflicts: # libraries/src/Dispatcher/ComponentDispatcher.php
Quy
reviewed
Nov 6, 2018
Quy
reviewed
Nov 6, 2018
Co-Authored-By: laoneo <[email protected]>
Co-Authored-By: laoneo <[email protected]>
ghost
added
the
J4 Issue
label
Apr 5, 2019
ghost
removed
the
J4 Issue
label
Apr 13, 2019
# Conflicts: # libraries/src/Authentication/Authentication.php # libraries/src/Extension/ExtensionManagerTrait.php # libraries/src/Plugin/PluginHelper.php # plugins/quickicon/joomlaupdate/Extension/Joomlaupdate.php
I honestly still don't really agree with this for the reasons mentioned earlier. But as per our discussion on glip earlier merged. |
This was referenced Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Loads the plugins through the boot functionality similar to what we have for modules and components.
A plugin needs then a file services/provider.php which does register the
PluginInterface::class
resource in the container:More information can be found in #19834, #20217 and #19667.
This is on hold till #19834 got merged as it is based on it.
Testing Instructions
Expected result
The joomla update check will be executed.
Actual result
All is working fine.
Documentation Changes Required
Needs to be documented like the component service locator stuff.