Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Fixing Suggestions in Finder/Smart Search #20523

Merged
merged 2 commits into from
May 23, 2018
Merged

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented May 21, 2018

The suggestions in Smart Search currently throw an error, because the controller can't find the right model. This fixes that.

Testing instructions

  1. Build the index in the backend.
  2. Go to the frontend to the Smart Search view and type in "joo". Notice nothing is happening.
  3. Apply patch
  4. Type in "joo" and see that you get lots of suggestions.

@carlitorweb
Copy link
Member

I have tested this item ✅ successfully on 2194013


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20523.

@infograf768
Copy link
Member

Firefox:
I lose focus when entering letters in the module field. I have to go back into it to add a letter.
finder_anim

And then, when I click on one of the results and click search I get a 404 and this
1055 'joomla_db_finder.t.parent_id' isn't in GROUP BY

@carlitorweb
Copy link
Member

carlitorweb commented May 22, 2018

@infograf768 I think this bug you mention is for a new issue. This PR is just for match the right model.

@infograf768
Copy link
Member

I have tested this item ✅ successfully on 2194013

For what it does, OK here.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20523.

@Hackwar
Copy link
Member Author

Hackwar commented May 23, 2018

@infograf768 The search issue that you mentioned is fixed in #20185. This here is only about suggestions.

@Quy
Copy link
Contributor

Quy commented May 23, 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20523.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 23, 2018
@laoneo laoneo added this to the Joomla 4.0 milestone May 23, 2018
@laoneo laoneo merged commit 7b29299 into joomla:4.0-dev May 23, 2018
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 23, 2018
@Hackwar Hackwar deleted the patch-22 branch May 23, 2018 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants