Add support for display docs and videos (same behaviour as J4) in the view used by media field #19967

ggppdk · 2018-03-23T05:07:37Z

Pull Request for Issues #10871 , #17475 , #19954

Summary of Changes

Added template files for documents and videos to the com_media view (imageslist) used by media field
Added template overrides to backend isis template
Added template overrides to frontend protostar template

Testing Instructions

(At Media Manager options)
Add pdf,mp4,PDF,MP4 to Legal Extensions
Add application/pdf,video/mp4 to Legal MIME types
Open an article and go to TAB image and links, click to select an image
Upload a PDF file and an MP4 file, click on each of them so that they get selected and click "Insert"

Expected result

The files are uploaded and shown and insertable

Actual result

The files are uploaded but not shown / not insertable

Documentation Changes Required

YES

Quy · 2018-03-23T15:04:01Z

administrator/components/com_media/views/imageslist/view.html.php

+
+		$this->docs    = &$docs;
+		$this->videos  = &$videos;
+		$this->videos  = &$videos;


Yes duplicate assignment, removed it

Quy · 2018-03-23T15:19:01Z

For image fields, PDFs should not be displayed/selectable.

With the PR, the PDF is selectable, but won't display on the frontend to be clickable.

<div class="pull-left item-image"> <img
			 src="/joomla-cms-staging/images/test.pdf" alt="" itemprop="image"/> </div>

ggppdk · 2018-03-23T15:30:44Z

For image fields, PDFs should not be displayed/selectable.
With the PR, the PDF is selectable, but won't display on the frontend to be clickable.

Yes non-images should not be selectable in the image fields

Using the image fields (of images and links TAB)
is just an easy example that this PR works

The selection for non-images for specific cases should be disallowed
but before i would add anything more i would like to see if there is interest in this PR and suggestions on how to limit the view

In my own views i am using ACL + a configuration id that corresponds to the configuration data in the DB to decide what is shown / not shown, and also do other customization on the view

Quy · 2018-04-01T02:23:40Z

administrator/components/com_media/views/imageslist/view.html.php

+	/**
+	 * Set the active video
+	 *
+	 * @param   integer  $index  Image position


yes, thanks

Quy · 2018-04-01T02:24:06Z

administrator/components/com_media/views/imageslist/view.html.php

+	/**
+	 * Set the active document
+	 *
+	 * @param   integer  $index  Image position


Document?

yes, thanks

Quy · 2018-04-01T02:27:15Z

administrator/components/com_media/views/imageslist/view.html.php

+	 *
+	 * @return  void
+	 *
+	 * @since   1.0


__DEPLOY_VERSION__

yes, thanks

Quy · 2018-04-01T02:27:22Z

administrator/components/com_media/views/imageslist/view.html.php

+	 *
+	 * @return  void
+	 *
+	 * @since   1.0


__DEPLOY_VERSION__

yes, thanks

Quy · 2018-04-01T02:30:54Z

administrator/components/com_media/views/imageslist/tmpl/default.php

@@ -47,8 +47,10 @@
 	);
 }
 ?>
-<?php if (count($this->images) > 0 || count($this->folders) > 0) : ?>
+<?php if (count($this->docs) > 0 || count($this->videos) > 0 || count($this->images) > 0 || count($this->folders) > 0) : ?>


How about moving count($this->docs) > 0 || count($this->videos) > 0 to the end since images are more likely to exist than docs and videos?

You are right, and i try to always remember for code that will be repeated

but in this case, it is only executed once per imagelist view opening,
thus the benefit would be only a couple of microseconds ... or less,
so i went for the order that the $this variables are defined in view.html.php,

or we could use the order the order that $this variables are used inside the IF:
folders, images, videos, docs

Also inside the IF the use of echo $this->loadTemplate('folder|image|video|doc'); inside loops
is really thousand times slower than this optimization, but even the above is hardly measurable because it is executed only a few dozens or hundrend times

laoneo · 2018-04-05T06:43:46Z

Can you do this feature against the Joomla 4 branch? Don't want to introduce a new feature in J3 which doesn't exist in 4, better to do it the other way around. Thanks!

robbiejackson · 2018-04-14T10:00:26Z

Hi, improvement this is really useful! I was diverted here after raising a change request #20057 but I'm not sure if the functionality is the same. Would you mind comparing the text of that issue?

In particular, can I just check if this change provides access to all types of media? I recently developed a website with media which included .gpx files (XML format files of GPS tracks), so would those be visible for example?

Also, I suggested being able to filter on the types of media shown – eg by MIME type or file extension.

Many thanks!

ggppdk · 2018-04-14T13:42:50Z

@laoneo

Can you do this feature against the Joomla 4 branch? Don't want to introduce a new feature in J3 which doesn't exist in 4, better to do it the other way around. Thanks!

this PR so far only adds the listing of doc / video files without any configuration
(the above is done as long as legal extensions / MIME are added to com_media configuration)
and this is already possible in J4

so you mean
implement configuration of which files should be allowed per instance of media field as a PR to 4.0-dev branch and close this one ? (this has not been added to this PR --yet--)

ggppdk · 2018-04-14T13:57:21Z

@robbiejackson

you do not need wait for this PR to do it in any J3 installation

you can do it today, just add 2 lines

$docs    = $this->get('documents');
$videos  = $this->get('videos');

to your Joomla template override of
administrator/components/com_media/views/imageslist/tmpl/default.php
as
templates/JTEMPLATENAME/html/com_media/imageslist/default.php
administrator/templates/JTEMPLATENAME/html/com_media/imageslist/default.php

**and then add 2 loops in it **
1 loop to list documents and 1 loop to list videos

copy code for the 2 loops from here and correct the variable name of each loop
https://github.com/joomla/joomla-cms/pull/19967/files#diff-fac76ead6ee179d0a6802a886ffd84b2
https://github.com/joomla/joomla-cms/pull/19967/files#diff-64721eb2e5a153801fced8b9bae84016

if you need more help to do the above then please ask in Joomla forums or in PHP programming forums

[EDIT]
of course add the
add additional legal extensions/mime types into com_media configuration

robbiejackson · 2018-04-14T16:31:19Z

@ggppdk
many thanks, I'll look into that,
Robbie

Quy · 2018-05-30T22:13:33Z

Escape filename like in #20616

Max00 · 2018-06-06T08:49:46Z

Do you think this PR will merge soon ?

ghost · 2018-06-06T10:09:27Z

@Max00 every PR need 2 successfully Test, before a Maintainer decide to merge or not.

So if you wan't to help, please test.

carlitorweb · 2018-06-06T15:52:40Z

@ggppdk will be good, now you add this great feature, the xtd-image button can do the same. Where the button put a link to the PDF (in case user select a PDF) or the <video></video> tag in case user select an .mp4 file.

infograf768 · 2018-07-04T11:22:44Z

@ggppdk
Would your PR solve #20969 ?

ggppdk · 2018-07-04T16:23:48Z

@infograf768

yes, but still this PR does not solve (yet) the configuration issue

You see there is the topic of how the MVC will decide that browsing docs and videos is allowed

Always showing all files

is not an option at all, since you will be listing all media files when someone only wants to view and select images

Using (-only-) a parameter in url

is not the way,since all existing websites after a joomla update, will suddenly allow this,

and someone by just by adding a parameter to the URL will be able to browse docs and videos in the media folder, before someone would need to know the filename for accessing a file

i suggest that the XTD button proposed in #20969
should have configuration in it

doc folder root for browsing doc files, which file extensions to list, etc and user-group(s) (or access level needed) for browsing

then you would add to the mediaelements URL
&conf_ext=editor_xtd&ext_id=NN

then you would read configuration from the plugin
and display will happen according to the configuration in the plugin and according to the access level (or user-groups) of current user

carlitorweb · 2018-07-10T14:06:50Z

@ggppdk we can test this PR, or you need still work in something more? I ask because of this:

but still this PR does not solve (yet) the configuration issue

So far, this PR only add the necessary layout for add that type of files, and if is all this PR will do, then we can test it, for see if we can have merged it. After that, we can use part of this code, in the xtd button feature

ggppdk · 2018-07-16T05:37:04Z

Thanks anyone spending time on this PR
No interest in spending more on it by me

Robdebert · 2018-09-13T16:04:45Z

@ggppdk Thank you so much for your code. I was able to use it completely as an override, without having to modify core-files.
That solved my problem with the media-manager in a modal-overlay (when using it as a field-type "media") and still my joomla can be updated :-)

ghost · 2018-09-13T16:53:01Z

@Robdebert your Comment on #19954 is resolve by your above?

level420 · 2019-01-04T15:32:19Z

@Robdebert would you mind sharing your override? Maybe as a gist? That would be great!

Robdebert · 2020-09-02T11:29:04Z

@level420 and @ghost: Sorry for the late reply.

I created a new issue, becuase i still think, that the media-fieldtype should use the same extensions as com_media allows, when editing the component-parameters. See #30548

Would be great, if you could support this new ticket, because the issue with the media-field is very old (i found a forum post from 2016 also).. and still Joomla-Core does not provide a modal-window fieldtype with the possibility to upload other files then images.

joomla-cms-bot added the PR-staging label Mar 23, 2018

Quy reviewed Mar 23, 2018

View reviewed changes

ggppdk force-pushed the media_field_doc_video_support branch from b6fcddb to 963c05b Compare March 27, 2018 08:11

ggppdk mentioned this pull request Mar 28, 2018

Option to show non-image files in the media form field #10871

Closed

Quy reviewed Apr 1, 2018

View reviewed changes

ggppdk added 3 commits April 1, 2018 08:27

Add support for display docs and videos in imagelist view

c8857ad

Remove duplicate assignment

e7fd193

Corrected method signature information in comments block

da879c3

ggppdk force-pushed the media_field_doc_video_support branch from 963c05b to da879c3 Compare April 1, 2018 05:40

Quy mentioned this pull request Apr 14, 2018

Request for standard form field type for all media in library #20057

Closed

Quy mentioned this pull request Jul 4, 2018

an xtd plugin to download media files #20969

Closed

ggppdk closed this Jul 16, 2018

Quy mentioned this pull request Oct 4, 2018

Media field does not allow to select files that are not images (PDF, ...) #19954

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for display docs and videos (same behaviour as J4) in the view used by media field #19967

Add support for display docs and videos (same behaviour as J4) in the view used by media field #19967

ggppdk commented Mar 23, 2018 •

edited

Loading

Quy Mar 23, 2018

ggppdk Mar 27, 2018

Quy commented Mar 23, 2018

ggppdk commented Mar 23, 2018 •

edited

Loading

Quy Apr 1, 2018

ggppdk Apr 1, 2018

Quy Apr 1, 2018

ggppdk Apr 1, 2018

Quy Apr 1, 2018

ggppdk Apr 1, 2018

Quy Apr 1, 2018

ggppdk Apr 1, 2018

Quy Apr 1, 2018

ggppdk Apr 1, 2018

laoneo commented Apr 5, 2018

robbiejackson commented Apr 14, 2018

ggppdk commented Apr 14, 2018 •

edited

Loading

ggppdk commented Apr 14, 2018 •

edited

Loading

robbiejackson commented Apr 14, 2018

Quy commented May 30, 2018

Max00 commented Jun 6, 2018

ghost commented Jun 6, 2018

carlitorweb commented Jun 6, 2018

infograf768 commented Jul 4, 2018

ggppdk commented Jul 4, 2018

carlitorweb commented Jul 10, 2018

ggppdk commented Jul 16, 2018

Robdebert commented Sep 13, 2018

ghost commented Sep 13, 2018

level420 commented Jan 4, 2019

Robdebert commented Sep 2, 2020

Add support for display docs and videos (same behaviour as J4) in the view used by media field #19967

Add support for display docs and videos (same behaviour as J4) in the view used by media field #19967

Conversation

ggppdk commented Mar 23, 2018 • edited Loading

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Quy commented Mar 23, 2018

ggppdk commented Mar 23, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

laoneo commented Apr 5, 2018

robbiejackson commented Apr 14, 2018

ggppdk commented Apr 14, 2018 • edited Loading

ggppdk commented Apr 14, 2018 • edited Loading

robbiejackson commented Apr 14, 2018

Quy commented May 30, 2018

Max00 commented Jun 6, 2018

ghost commented Jun 6, 2018

carlitorweb commented Jun 6, 2018

infograf768 commented Jul 4, 2018

ggppdk commented Jul 4, 2018

carlitorweb commented Jul 10, 2018

ggppdk commented Jul 16, 2018

Robdebert commented Sep 13, 2018

ghost commented Sep 13, 2018

level420 commented Jan 4, 2019

Robdebert commented Sep 2, 2020

ggppdk commented Mar 23, 2018 •

edited

Loading

ggppdk commented Mar 23, 2018 •

edited

Loading

ggppdk commented Apr 14, 2018 •

edited

Loading

ggppdk commented Apr 14, 2018 •

edited

Loading