-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CS] long form function return types; round 2 #19935
Changes from 8 commits
9526a8e
53d0435
19fa7d5
7233dfb
d073bb9
4f7f7c9
7cd8517
1d284f8
deeabb0
4353743
bb6aa47
19bc565
7e3531a
b3c3304
19e2da8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,18 +18,53 @@ | |
*/ | ||
class TagsViewTag extends JViewLegacy | ||
{ | ||
/** | ||
* The model state | ||
* | ||
* @var \Joomla\Registry\Registry | ||
*/ | ||
protected $state; | ||
|
||
/** | ||
* An array of items. | ||
* | ||
* @var array | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See line 45. Here 3 spaces. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Technically we need since tags with a Class Property, and then the var tag will align with that position. |
||
*/ | ||
protected $items; | ||
|
||
/** | ||
* The active JObject (on success, false on failure) | ||
* | ||
* @var JObject|boolean | ||
*/ | ||
protected $item; | ||
|
||
/** | ||
* Array of Children objects | ||
* | ||
* @var array | ||
*/ | ||
protected $children; | ||
|
||
/** | ||
* The pagination object. | ||
* | ||
* @var JPagination | ||
*/ | ||
protected $pagination; | ||
|
||
/** | ||
* The application parameters | ||
* | ||
* @var \Joomla\Registry\Registry The parameters object | ||
*/ | ||
protected $params; | ||
|
||
/** | ||
* Array of tags title | ||
* | ||
* @var array | ||
*/ | ||
protected $tags_title; | ||
|
||
/** | ||
|
@@ -204,7 +239,7 @@ public function display($tpl = null) | |
/** | ||
* Prepares the document. | ||
* | ||
* @return void | ||
* @return void | ||
*/ | ||
protected function _prepareDocument() | ||
{ | ||
|
@@ -292,7 +327,7 @@ protected function _prepareDocument() | |
/** | ||
* Creates the tags title for the output | ||
* | ||
* @return bool | ||
* @return boolean | ||
*/ | ||
protected function getTagsTitle() | ||
{ | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -227,7 +227,7 @@ protected function getLanguageManifest($uid) | |
* | ||
* @param string $remote_manifest URL to the manifest XML file of the remote package. | ||
* | ||
* @return string|bool | ||
* @return string|boolean | ||
* | ||
* @since 3.1 | ||
*/ | ||
|
@@ -244,7 +244,7 @@ protected function getPackageUrl($remote_manifest) | |
* | ||
* @param string $url URL of the package. | ||
* | ||
* @return array|bool Package details or false on failure. | ||
* @return array|boolean Package details or false on failure. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 2 spaces after |
||
* | ||
* @since 3.1 | ||
*/ | ||
|
@@ -1418,7 +1418,7 @@ public function addAssociations($groupedAssociations) | |
/** | ||
* Retrieve the admin user id. | ||
* | ||
* @return int|bool One Administrator ID. | ||
* @return integer|boolean One Administrator ID. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 2 spaces after |
||
* | ||
* @since 3.2 | ||
*/ | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -633,7 +633,7 @@ public function redirect($url, $status = 303) | |
* | ||
* @param integer $state The HTTP 1.1 status code. | ||
* | ||
* @return bool | ||
* @return boolean | ||
* | ||
* @since 3.8.0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Align |
||
*/ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move after
@access