Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS] Code Style fixes for administrator/components,modules,templates #19173

Merged
merged 1 commit into from
Jan 10, 2018

Conversation

photodude
Copy link
Contributor

@photodude photodude commented Dec 26, 2017

Pull Request for Issue code style fixes

Summary of Changes

  • Please consider an empty line before the try/foreach statement
  • Whitespace found at end of line
  • Expected 1 space after "="; 2 found
  • Expected 1 space before "="; 0 found
  • Please consider an empty line before the return statement;
  • Expected 1 newline after opening brace; 2 found
  • Blank line found at start of control structure
  • Please consider an empty line before the if statement;
  • Line indented incorrectly;

Automatically fixed with Joomla code standards 2.0.0 PHPCS2-alpha2 fixers

None of the manual only fixes have been applied

Testing Instructions

Merge by code review

Expected result

code style has been applied as listed above, old code style testing on drone does not error.

Actual result

code style had not been applied. Autofixers from the Joomla code standards 2.0.0 PHPCS2 alpha2 were used to implement fixable code style

Documentation Changes Required

none

- Please consider an empty line before the try/foreach statement
- Whitespace found at end of line
- Expected 1 space after "="; 2 found
- Expected 1 space before "="; 0 found
- Please consider an empty line before the return statement;
- Expected 1 newline after opening brace; 2 found
- Blank line found at start of control structure
- Please consider an empty line before the if statement;
- Line indented incorrectly;
@Quy
Copy link
Contributor

Quy commented Dec 26, 2017

I have tested this item ✅ successfully on c30373f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19173.

@photodude photodude changed the title CS] Code Style fixes for administrator/components,modules,templates [CS] Code Style fixes for administrator/components,modules,templates Dec 26, 2017
@wilsonge wilsonge merged commit 7d3a3ef into joomla:staging Jan 10, 2018
@wilsonge wilsonge added this to the Joomla 3.8.4 milestone Jan 10, 2018
@photodude photodude deleted the PHPCS2-admin branch January 10, 2018 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants