[4.0] Kill grunt! #18446

dgrammatiko · 2017-10-30T09:56:12Z

Pull Request for Issue # .

Summary of Changes

Two years ago (or so) I did this Grunt file with the aim to lift some of the day to day tasks for maintainers and also provide an easy way for contributors to compile scss files and minify js and css.
As the project (J4) moved on we added a lot more functionality and the file reached about 800 lines of code, which is kinda awkward for a task runner file.
Also we already encounter (a few times) that plugins will fall out of sync with the latest releases of the underlaying scripts (postfix, uglify, etc).
Therefore I propose a a better (for the long term) solution: plain node js code, no Grunt, no Gulp, no Webpack or Rollup. The tasks are pretty straight forward and we're not doing any packaging so webpack and rollup are totally out of the picture.
Also we are now using the package.json as the only point of truth (used to be another yaml file)

Available Commands

Compile css

node build --compilecss

Prepare the installation language.js

node build --installer

Compile/compress js

node build --compilejs

Update all vendor dependencies

node build --update

Expected result

Same functionality as Grunt (some command)

Documentation Changes Required

For documentation just run

node build --help

or just

node build

Enjoy!

Preview

dgrammatiko · 2017-10-30T09:59:04Z

I forgot to mention that:
compilecss and compilejs options produce ALWAYS the same output, compared to the mess we had in grunt!

C-Lodder · 2017-10-30T16:40:13Z

You appear to be loading the wrong jQuery UI package from NPM.

Should be this: https://www.npmjs.com/package/jquery-ui
not this: https://www.npmjs.com/package/jquery-ui-dist

C-Lodder · 2017-10-30T16:42:10Z

Also, can we kill the uncompressed CSS files please? We're not using them at all.

C-Lodder · 2017-10-30T16:45:25Z

package.json

+              {
+                "targets": {
+                  "browsers": [
+                    "last 2 versions",


should be last 1 version

this one is for babel, not postcss

C-Lodder · 2017-10-30T16:47:09Z

build/build-modules-js/update.js

+
+			// Update the XML files for Codemirror
+			let codemirrorXml = fs.readFileSync(rootPath + '/plugins/editors/codemirror/codemirror.xml', {encoding: 'UTF-8'});
+			codemirrorXml = codemirrorXml.replace(xmlVersionStr, "$1" + options.dependencies.tinymce + "$3");


options.dependencies.tinymce should be options.dependencies.codemirror as you've reverted Codemirror back to 4.7.1 :)

mbabker · 2017-10-30T16:47:34Z

Also, can we kill the uncompressed CSS files please? We're not using them at all.

Unless you're going to kill support for the core templates and core media loading uncompressed files in debug mode they should stay.

C-Lodder · 2017-10-30T16:52:20Z

@mbabker - Atum doesn't have any uncompressed CSS files and works perfectly fine in debug mode: https://github.com/joomla/joomla-cms/tree/4.0-dev/administrator/templates/atum/css

mbabker · 2017-10-30T16:52:44Z

I know it all works fine in debug mode. JHtml only uses uncompressed if it can take a .min.foo filename, convert it to .foo, and find a file that exists. So if uncompressed media doesn't exist then the compressed file still gets loaded.

This might be OK for the template media, but it should still be possible to get the core media in uncompressed format. Which means either we keep them in repo & ship them or people have to go through extra steps to compile them.

Fedik · 2017-11-02T15:57:51Z

@DGT41 it is still WIP?

I got error:

Fedik · 2017-11-02T16:36:13Z

@DGT41 ignore me, all works fine

Fedik · 2017-11-03T12:26:12Z

@DGT41 one note:

       "srcjs": "dist",
       "srccss": "dist",
        "filesjs": [
          "cropper.js",
          "cropper.min.js",
          "cropper.js.map"
        ],

I found it confusing, because you have "srcjs": "dist", and dist usually contain distributive files, not source 😉

And question.
Is there no way to get the module path, and scan for available files, automatically?
something like :

var pathToModule = require.resolve('moduleBlabLa');
var files = scanforJsCss(pathToModule);

dgrammatiko · 2017-11-03T14:01:32Z

@Fedik that's an interesting idea, I have to explore that

C-Lodder · 2017-11-17T14:37:26Z

Could we get the conflicts on this fixed please and then merge?

Any improvements can be made at a later date

dgrammatiko · 2017-12-31T10:24:23Z

Grrrr

C-Lodder · 2017-12-31T10:29:08Z

Just recompile and remove the grunt-settings.yaml

dgrammatiko · 2017-12-31T17:58:12Z

@wilsonge important please merge this!!

C-Lodder · 2018-01-02T22:36:39Z

@wilsonge please merge. This is a choice made by the JS team and will also assist the Ciaran and myself who are the primary people making use of the feature.

dgrammatiko · 2018-01-04T18:15:54Z

@wilsonge any decision here, before you merge more things and make this harder to get it again in sync?

wilsonge · 2018-01-16T21:01:40Z

Fix the conflicts and I'll merge it. I'm very uneasy about this to be honest. I still think gulp might be better for us. But let's just get it in so it's not blocking you guys

…ix, uglify

dgrammatiko · 2018-01-17T19:51:58Z

This is in-sync again. Ping @wilsonge

wilsonge · 2018-01-17T21:02:32Z

You need to fix travis please

dgrammatiko · 2018-01-17T21:14:44Z

Travis is happy again

dgrammatiko · 2018-01-17T21:25:44Z

Thank you!

* [4.0] Remove grunt in favour of native node build scripts (joomla#18446) * These are junk * First pass on converting JS * Fix path to loader * CS tweaks for IFW JS, move event listener registration into success callback so that the changed DOM elements correctly receive them, change how custom events are triggered so they'll actually work * Make sure elements exist in DOM

infograf768 · 2018-01-19T08:10:49Z

@DGT41
I'm afraid this has broken, among other stuff, the radio field on Firefox.
See #19403

C-Lodder · 2018-01-19T08:58:42Z

We are in the process pf fixing things

* [4.0] Remove grunt in favour of native node build scripts (#18446) * These are junk * First pass on converting JS * Fix path to loader * CS tweaks for IFW JS, move event listener registration into success callback so that the changed DOM elements correctly receive them, change how custom events are triggered so they'll actually work * Make sure elements exist in DOM

joomla-cms-bot added the PR-4.0-dev label Oct 30, 2017

C-Lodder reviewed Oct 30, 2017

View reviewed changes

dgrammatiko and others added 10 commits January 17, 2018 20:43

init

36208ba

fixes

aaf7854

Update of update.js and package.json

4f44dd5

Allow to compile only specific folder/file

520bb71

sync

884c01f

Fix the intallation js for the error page

207eea5

sync

141ac62

Add the licenses, rename couple folders, remove unused libs

f78b0c6

keep jquery-ui out of the automation

0dc1a38

code for the custom elements: copy, transpile, compile scss, autopref…

a67fa03

…ix, uglify

tests

cf49472

wilsonge merged commit 122281a into joomla:4.0-dev Jan 17, 2018

wilsonge added this to the Joomla 4.0 milestone Jan 17, 2018

dgrammatiko deleted the §4.0-dev-kill-grunt branch January 17, 2018 21:24

infograf768 mentioned this pull request Jan 19, 2018

[4.0] Joomal switcher radio field broken for Firefox #19403

Closed

astridx mentioned this pull request Feb 6, 2018

[4.0] Loop to get the files that should be compiled via parameter #19581

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[4.0] Kill grunt! #18446

[4.0] Kill grunt! #18446

dgrammatiko commented Oct 30, 2017 •

edited

Loading

dgrammatiko commented Oct 30, 2017

C-Lodder commented Oct 30, 2017

C-Lodder commented Oct 30, 2017

C-Lodder Oct 30, 2017

dgrammatiko Oct 30, 2017

C-Lodder Oct 30, 2017 •

edited

Loading

dgrammatiko Oct 30, 2017

mbabker commented Oct 30, 2017

C-Lodder commented Oct 30, 2017 •

edited

Loading

mbabker commented Oct 30, 2017

Fedik commented Nov 2, 2017

Fedik commented Nov 2, 2017

Fedik commented Nov 3, 2017

dgrammatiko commented Nov 3, 2017

C-Lodder commented Nov 17, 2017 •

edited

Loading

dgrammatiko commented Dec 31, 2017

C-Lodder commented Dec 31, 2017

dgrammatiko commented Dec 31, 2017

C-Lodder commented Jan 2, 2018

dgrammatiko commented Jan 4, 2018

wilsonge commented Jan 16, 2018

dgrammatiko commented Jan 17, 2018

wilsonge commented Jan 17, 2018

dgrammatiko commented Jan 17, 2018

dgrammatiko commented Jan 17, 2018

infograf768 commented Jan 19, 2018

C-Lodder commented Jan 19, 2018

[4.0] Kill grunt! #18446

[4.0] Kill grunt! #18446

Conversation

dgrammatiko commented Oct 30, 2017 • edited Loading

Summary of Changes

Available Commands

Expected result

Documentation Changes Required

Preview

dgrammatiko commented Oct 30, 2017

C-Lodder commented Oct 30, 2017

C-Lodder commented Oct 30, 2017

C-Lodder Oct 30, 2017

Choose a reason for hiding this comment

dgrammatiko Oct 30, 2017

Choose a reason for hiding this comment

C-Lodder Oct 30, 2017 • edited Loading

Choose a reason for hiding this comment

dgrammatiko Oct 30, 2017

Choose a reason for hiding this comment

mbabker commented Oct 30, 2017

C-Lodder commented Oct 30, 2017 • edited Loading

mbabker commented Oct 30, 2017

Fedik commented Nov 2, 2017

Fedik commented Nov 2, 2017

Fedik commented Nov 3, 2017

dgrammatiko commented Nov 3, 2017

C-Lodder commented Nov 17, 2017 • edited Loading

dgrammatiko commented Dec 31, 2017

C-Lodder commented Dec 31, 2017

dgrammatiko commented Dec 31, 2017

C-Lodder commented Jan 2, 2018

dgrammatiko commented Jan 4, 2018

wilsonge commented Jan 16, 2018

dgrammatiko commented Jan 17, 2018

wilsonge commented Jan 17, 2018

dgrammatiko commented Jan 17, 2018

dgrammatiko commented Jan 17, 2018

infograf768 commented Jan 19, 2018

C-Lodder commented Jan 19, 2018

dgrammatiko commented Oct 30, 2017 •

edited

Loading

C-Lodder Oct 30, 2017 •

edited

Loading

C-Lodder commented Oct 30, 2017 •

edited

Loading

C-Lodder commented Nov 17, 2017 •

edited

Loading