Third batch of module tmpl codestyle #17855
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quy
reviewed
Sep 3, 2017
modules/mod_menu/tmpl/default.php
Outdated
| <?php endif; ?> | ||
| <?php // The next item is deeper. ?> | ||
| <?php if ($item->deeper) : ?> | ||
| <?php echo '<ul class="nav-child unstyled small">'; ?> |
Quy
reviewed
Sep 3, 2017
modules/mod_menu/tmpl/default.php
Outdated
| <?php echo '<ul class="nav-child unstyled small">'; ?> | ||
| <?php elseif ($item->shallower) : ?> | ||
| <?php // The next item is shallower. ?> | ||
| <?php echo '</li>'; ?> |
Quy
reviewed
Sep 3, 2017
modules/mod_menu/tmpl/default.php
Outdated
| <?php echo str_repeat('</ul></li>', $item->level_diff); ?> | ||
| <?php else : ?> | ||
| <?php // The next item is on the same level. ?> | ||
| <?php echo '</li>'; ?> |
|
I have tested this item ✅ successfully on 90aef02 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17855. |
|
can we have a second review & merged here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Third batch of module tmpl codestyle
Testing Instructions
Please test and review the following frontend modules using the testing sampledata
Expected result
Still works
Actual result
Works with codestyle problems
Documentation Changes Required
none