second batch of module tmpl codestyle #17852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zero-24
changed the title
brianteeman
reviewed
Sep 3, 2017
modules/mod_feed/tmpl/default.php
Outdated
| <?php $lang = JFactory::getLanguage(); ?> | ||
| <?php $myrtl = $params->get('rssrtl'); ?> | ||
| <?php $direction = ' '; ?> | ||
| <?php $isRtl = $lang->isRtl(); ?> |
There was a problem hiding this comment.
Not sure why the first three lines above are aligned on the = but the line below is not?
There was a problem hiding this comment.
they was aligned because they where PHP only code i have reset the aligned. (comming with the next commit)
brianteeman
reviewed
Sep 3, 2017
| <?php endif; ?> | ||
| <?php if ($params->get('dropdown', 1) && !$params->get('dropdownimage', 0)) : ?> | ||
| <form name="lang" method="post" action="<?php echo htmlspecialchars(JUri::current(), ENT_COMPAT, 'UTF-8'); ?>"> | ||
| <select class="inputbox advancedSelect" onchange="document.location.replace(this.value);" > |
There was a problem hiding this comment.
do we need the space before the > at the end?
Quy
reviewed
Sep 3, 2017
| @@ -27,7 +27,7 @@ | |||
| <?php endif; ?> | |||
| <?php if ($params->get('dropdown', 1) && !$params->get('dropdownimage', 0)) : ?> | |||
| <form name="lang" method="post" action="<?php echo htmlspecialchars(JUri::current(), ENT_COMPAT, 'UTF-8'); ?>"> | |||
| <select class="inputbox advancedSelect" onchange="document.location.replace(this.value);" > | |||
| <select class="inputbox advancedSelect" onchange="document.location.replace(this.value);"> | |||
| <?php foreach ($list as $language) : ?> | |||
| <option dir=<?php echo $language->rtl ? '"rtl"' : '"ltr"'; ?> value="<?php echo $language->link; ?>" <?php echo $language->active ? 'selected="selected"' : ''; ?>> | |||
There was a problem hiding this comment.
Change to "<?php echo $language->rtl ? 'rtl' : 'ltr'; ?>"
Quy
reviewed
Sep 3, 2017
modules/mod_feed/tmpl/default.php
Outdated
| <?php elseif ($myrtl == 0) : ?> | ||
| <?php $direction = ' redirect-ltr'; ?> | ||
| <?php elseif ($myrtl == 1): ?> | ||
| <?php $direction = ' redirect-ltr';?> |
Quy
reviewed
Sep 3, 2017
| @@ -29,7 +29,7 @@ | |||
| <form name="lang" method="post" action="<?php echo htmlspecialchars(JUri::current(), ENT_COMPAT, 'UTF-8'); ?>"> | |||
| <select class="inputbox advancedSelect" onchange="document.location.replace(this.value);"> | |||
| <?php foreach ($list as $language) : ?> | |||
| <option dir=<?php echo $language->rtl ? '"rtl"' : '"ltr"'; ?> value="<?php echo $language->link; ?>" <?php echo $language->active ? 'selected="selected"' : ''; ?>> | |||
| <option dir=<?php echo $language->rtl ? 'rtl' : 'ltr'; ?> value="<?php echo $language->link; ?>" <?php echo $language->active ? 'selected="selected"' : ''; ?>> | |||
There was a problem hiding this comment.
Missing beginning and ending "
Quy
reviewed
Sep 3, 2017
| ?> | ||
|
|
||
| <?php // Show the form fields. ?> | ||
| <?php echo $output; ?> | ||
| <?php $show_advanced = $params->get('show_advanced'); ?> | ||
| <?php if ($show_advanced == 2) : ?> | ||
| <br /> |
Quy
reviewed
Sep 3, 2017
modules/mod_login/tmpl/default.php
Outdated
| <?php echo JText::_('MOD_LOGIN_REMEMBER_ME'); ?> | ||
| </label> | ||
| <input id="modlgn-remember" type="checkbox" name="remember" class="inputbox" value="yes" /> | ||
| </div> | ||
| <?php endif; ?> | ||
| <div id="form-login-submit" class="control-group"> | ||
| <div class="controls"> | ||
| <button type="submit" tabindex="0" name="Submit" class="btn btn-primary login-button"><?php echo JText::_('JLOGIN'); ?></button> |
Quy
reviewed
Sep 4, 2017
modules/mod_feed/tmpl/default.php
Outdated
| <?php endif; ?> | ||
| <?php // Feed image ?> | ||
| <?php if ($iUrl && $params->get('rssimage', 1)) : ?> | ||
| <img src="<?php echo $iUrl; ?>" alt="<?php echo @$iTitle; ?>"/> |
Quy
reviewed
Sep 4, 2017
modules/mod_feed/tmpl/default.php
Outdated
| @@ -10,115 +10,80 @@ | |||
| defined('_JEXEC') or die; | |||
| ?> | |||
There was a problem hiding this comment.
Add line before ?> and delete line after ?>.
* Add space * Add space
Quy
reviewed
Sep 12, 2017
modules/mod_login/tmpl/default.php
Outdated
| <div class="input-prepend input-append"> | ||
| <span class="add-on"> | ||
| <span class="icon-star hasTooltip" title="<?php echo JText::_('JGLOBAL_SECRETKEY'); ?>"> | ||
| </span> |
There was a problem hiding this comment.
Move </span> to line 71 to be consistent with https://github.com/joomla/joomla-cms/pull/17852/files#diff-865b73156d929ab9f11d62196125ec9aR50
Quy
reviewed
Sep 14, 2017
| @@ -28,12 +28,16 @@ | |||
| <div class="input-prepend"> | |||
There was a problem hiding this comment.
Line 21: multiple lines like https://github.com/joomla/joomla-cms/pull/17852/files#diff-865b73156d929ab9f11d62196125ec9aL121
|
I have tested this item ✅ successfully on 6cbe566 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17852. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
First batch of module tmpl codestyle
Testing Instructions
Please test and review the following frontend modules using the testing sampledata
Expected result
Still works
Actual result
Works with codestyle problems
Documentation Changes Required
none