Contact form loses data after postback with error

[sandewt]

Pull Request for issue #17126.

Summary of Changes

Some code.

Testing Instructions

Instructions, see issue #17126

• Go to Single Contact.
• Fill in the form.
• Do not fill in captcha.
• Send email.

Expected result

Warning + textboxes are NOT empty.

Actual result

All textboxes are empty, so the user has to fill in AGAIN all textboxes.

Documentation Changes Required

No.

Thanks to

@pascal-910

[sandewt]

I'm new on Github.
If I have downloaded the code and look to the characters.
So I see in my editer, that after the "{" and the "}" braces (accolades) is a tab. In line 76 and 78. (NOK.)
How can I avoid this in github by making a PR?

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17743.}

[sandewt]

Ask for input.

Is the following code nessecary?

empty($item->catid)

In the DB table xxx_content is defined:

`catid` int(10) UNSIGNED NOT NULL DEFAULT '0'

So the catid may not be empty !?

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17743.}

[n9iels]

The patch works fine for me.

Is the following code nessecary?

There is never a problem with extra test :-). However in this situation only !empty($item->catid) is enough. !isset($item->catid) will only check if the $item object has a 'catid' property. !empty($item->catid) will check if the $item object has a 'catid' property, and this property is not empty. See this post for more information:

https://stackoverflow.com/questions/7191626/isset-and-empty-what-to-use#answer-7191642

If you change this I can conform the test via the J!Issue tracker.

[sandewt]

Thanks, interesting post.

Do you mean!empty($item->catid) or empty($item->catid) is enough? Because catid is not empty.
The function $app->setUserState(..) may not be executed in this situation!

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17743.}

[sandewt]

Do not fiil in captcha. After send all data form loses after postback !!!

[sandewt]

Sorry, a mistake for closing!!

[sandewt]

Please test this PR #17126 or give comment.

[conconnl]

I have tested this item ✅ successfully on 8004b7a

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17743.}

[slibbe]

I have tested this item ✅ successfully on 8004b7a

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17743.}

[ghost]

RTC after two successful tests.

[wojsmol]

@franz-wohlkoenig Please see @n9iels #17743 (comment)
@sandewt Can you address this #17743 (comment)?

[ghost]

@wojsmol means this Comment not RTC?

[wojsmol]

@franz-wohlkoenig Let's leve desicion to one of maainterners. Code my to be a little simpler, but both versions works.

[sandewt]

On closer inspection and the comments, the following:

In the Joomla! core rarely used the combination of 'isset and empty', and not for no reason.
So I choise for the proposal of @niels that one test is enough.
I expect a string for $item->catid (gettype) which is p.e. '16'. And not '' or '0'.
So I prefer 'empty' in stead of '!isset' if the user state ($app->setUserState) is not yet set.
See also: http://php.net/manual/en/types.comparisons.php

So I changed the code, PLEASE TEST AGAIN.

[sandewt]

Sorry for closing, issue should be open @franz-wohlkoenig.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17743.}

[brianteeman]

re-opened

[sandewt]

Thanks Brian, and @niels should be @n9iels.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17743.}

[Quy]

I have tested this item ✅ successfully on 9377adb

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17743.}

[ghost]

@conconnl @slibbe can one of you please test?

[Sieger66]

I have tested this item ✅ successfully on 9377adb

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17743.}

[Quy]

RTC

[ReLater]

Looks like this pr has opened another issue. See #20195 please.

[infograf768]

@sandewt
Please look at #20195 (comment)