-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert any special characters from 'Site Name' settled in Global Con… #17209
Conversation
…figuration Example Site name: my "website name" HTML output without this change: <img src="/administrator/templates/isis/images/joomla.png" alt="my " website="" name""=""> with this change: <img src="/administrator/templates/isis/images/joomla.png" alt="my "website name"">
Not checked this but surely if it correct them the change has to be made everywhere that we get the sitemap!e and not just in the login |
The change is correct when the site name is used in html. |
Please add some detailed test instructions This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17209. |
@Heggi93 pretty much as it says in the original post. In global configuration create a site name with a special character eg On the administrator login page view the source code for the joomla logo. Before this PR the alt text will be invalid markup. After this PR the alt text should be valid markup. Note that if correct then this change needs to be used in other places that we use the $sitename variable in a similar way |
I have tested this item ✅ successfully on d6c89e6 Source Code without PR:Source Code with PR:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17209. |
I have tested this item ✅ successfully on d6c89e6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17209. |
RTC after two successful tests. |
…figuration
Example
Site name: my "website name"
HTML output
without this change:
<img src="/administrator/templates/isis/images/joomla.png" alt="my " website="" name""="">
with this change:
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Expected result
Actual result
Documentation Changes Required