Inform users that Force HTTPS config option will also force the usage of secure cookies #16511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on f1350f3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16511. |
|
I have tested this item ✅ successfully on f1350f3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16511. |
|
RTC after two successful tests. |
joomla-cms-bot
added
PR-staging
and removed
RTC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for New Issue.
Summary of Changes
When we enabled "Force HTTPS" Joomla will also force the use of secure cookies.
The user currently is not informed of this.
Why the proposed change:
We can have several ways of forcing HTTPS in a website, for instance, at web server level, ie, without even using Joomla "Force HTTPS" option (leaving it to "None").
But forcing http to https redirect at web server level will not force the cookies to be secure, Joomla "Force HTTPS" config option force the use of https AND forces the use of secure session cookies, so IMHO is relevant for server admin to know that.
Testing Instructions
Language review.
Expected result
User informed that site will also use secure cookies.
Actual result
Not informed.
Documentation Changes Required
None.