Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] dropdown #15046

Merged
merged 16 commits into from
May 24, 2017
Merged

[a11y] dropdown #15046

merged 16 commits into from
May 24, 2017

Conversation

brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Apr 1, 2017

Continuing the work to prevent assistive technology reading out the value of an icon. This PR addresses the icons in com_contact, com_messages, com_contact an com_redirect as show in the screenshots below.

screenshotr19-51-04

screenshotr20-01-38

screenshotr20-06-56

screenshotr20-16-42

@brianteeman
Copy link
Contributor Author

If anyone is able to help updating the unit tests I would appreciate it @yvesh @zero-24

@zero-24
Copy link
Contributor

zero-24 commented Apr 1, 2017

I have just send you a PR for the drone error. The phpunit thing looks strange to me on a first quick look. I need to check that with @yvesh

@zero-24
Copy link
Contributor

zero-24 commented Apr 1, 2017

Travis is green now too. Thanks @yvesh and @brianteeman

@brianteeman
Copy link
Contributor Author

Thanks for the help there @zero-24 @yvesh

@brianteeman
Copy link
Contributor Author

any testers?

@ghost
Copy link

ghost commented Apr 5, 2017

@brianteeman is this code review or how to test?

@tonypartridge
Copy link
Contributor

I have tested this item ✅ successfully on 58ee500

Code Review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15046.

@Quy
Copy link
Contributor

Quy commented May 24, 2017

I have tested this item ✅ successfully on 58ee500

Code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15046.

@ghost
Copy link

ghost commented May 24, 2017

RTC after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 24, 2017
@zero-24 zero-24 added this to the Joomla 3.7.3 milestone May 24, 2017
@rdeutz rdeutz merged commit 93a90ec into joomla:staging May 24, 2017
@joomla-cms-bot joomla-cms-bot added Unit/System Tests and removed RTC This Pull Request is Ready To Commit labels May 24, 2017
@brianteeman
Copy link
Contributor Author

Thanks

@brianteeman brianteeman deleted the a11y_dropdown branch May 24, 2017 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants