Execute sql uninstall query (if exists) on extension install abort

[andrepereiradasilva]

Pull Request for New Issue.

Summary of Changes

Currently when a extension install is aborted and the install sql query already run we get a broken install.
The extension is uninstalled but the database tables will stay in joomla.

This PR proposes to change that by adding a step to rollback the sql (if an uninstall sql exists).

Testing Instructions

1. Code review
2. Install this broken com_test.zip extension that install with a db table called #__test. Notice you get the extension install rollback but you stay with the #__test table in the database
3. Manually delete the #__test table
4. Apply patch
5. Repeat step 2 and notice now on failure the #__test table is also removed.

Documentation Changes Required

None.

[frankmayer]

I haven't tested this yet, but one question comes to mind:
What happens if an extension is installed on top of the same? I am thinking of updating an extension by installing it on top of itself.
If that "update" fails, wouldn't it destroy for example the data of the previously working extension?

[andrepereiradasilva]

that's why i putted the if ($route === 'install'
https://github.com/joomla/joomla-cms/pull/13376/files#diff-b88334a2e44587a12ed5fed7beb8bd1eR478

But please test that scenario also

[frankmayer]

I have tested this item ✅ successfully on f504164

Done code review.

Note: I also tested installing the extension completely (by removing the exception) and then re-installing the broken one (with the addition of an exception in the update method). The existing table stayed intact, as expected.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13376.}

[ggppdk]

That's why i putted the if ($route === 'install'
https://github.com/joomla/joomla-cms/pull/13376/files#diff-b88334a2e44587a12ed5fed7beb8bd1eR478
But please test that scenario also

Exactly my fear it would be destructive, i will test too

I mean i ll test to "update" an already installed extension with a broken package

[alikon]

I have tested this item ✅ successfully on f504164

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13376.}

[jeckodevelopment]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13376.}