Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_fields] Fix notices in contact view #12729

Merged
merged 1 commit into from
Nov 5, 2016

Conversation

Bakual
Copy link
Contributor

@Bakual Bakual commented Nov 3, 2016

Pull Request for Issue #12728

Summary of Changes

  • render_class is a param, not an object property.
  • The $fields array doesn't always start with the key 0. This PR uses reset to get the first item.

Testing Instructions

  • Create multiple custom fields for contacts and set the "edit value" permissions so it is allowed by public. Set the fields to different positions (unter tab options -> automatic display)
  • Edit a contact to add some value to those fields.
  • View that contact in frontend.

Before PR you get multiple notices after PR they are gone.

Documentation Changes Required

None

@Bakual Bakual changed the title Fix notices in contact view [com_fields] Fix notices in contact view Nov 3, 2016
@RickR2H
Copy link
Member

RickR2H commented Nov 4, 2016

I have tested this item ✅ successfully on 188cfeb

Notices where gone after patch install


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12729.

@AnnemiekStoel
Copy link

I have tested this item ✅ successfully on 188cfeb

Test succesful


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12729.

@zero-24 zero-24 added this to the Joomla 3.7.0 milestone Nov 4, 2016
@zero-24
Copy link
Contributor

zero-24 commented Nov 4, 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12729.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 4, 2016
@rdeutz rdeutz merged commit 893f4e2 into joomla:staging Nov 5, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 5, 2016
@Bakual Bakual deleted the FixNoticesContactFields branch November 5, 2016 12:12
nvyush pushed a commit to nvyush/joomla-cms that referenced this pull request Nov 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants