Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_fields] Change key to name as for lists #12698

Merged
merged 1 commit into from
Nov 6, 2016

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Nov 2, 2016

Pull Request for Issue #12673.

Summary of Changes

Changes the key of the list options to the structure needed by the list.

Testing Instructions

  • Create a radio or checkbox field for Articles with some options.
  • Create an article.
  • Open the fields tab.

Expected result

The checkboxes or radio button should be shown.

@laoneo laoneo changed the title Change key to name as for lists [com:fields] Change key to name as for lists Nov 2, 2016
@laoneo laoneo changed the title [com:fields] Change key to name as for lists [com_fields] Change key to name as for lists Nov 2, 2016
@ggppdk
Copy link
Contributor

ggppdk commented Nov 5, 2016

I have tested this item ✅ successfully on 772fbdc

Please merge this, because fields checkboxes and radio do not show, the PHP code expects "name" and not "key"

this change is included in this PR too: #12739


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12698.

@jeckodevelopment
Copy link
Member

I have tested this item ✅ successfully on 772fbdc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12698.

@jeckodevelopment
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12698.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 5, 2016
@jeckodevelopment jeckodevelopment added this to the Joomla 3.7.0 milestone Nov 5, 2016
@rdeutz rdeutz merged commit 4caaa2b into joomla:staging Nov 6, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 6, 2016
nvyush pushed a commit to nvyush/joomla-cms that referenced this pull request Nov 9, 2016
@laoneo laoneo deleted the list-options branch January 26, 2017 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants