Fix double parameters creation for parameters of home template and of template override

[ggppdk]

Pull Request for Issue #12651

Summary of Changes

The home template styles are cloned, inside the foreach loop (see the modified code) and then added to the same array: $templates

as $templates[0]

thus parameters creation for template home: $templates[0]
will happen twice

Testing Instructions

Styles are applied as configured

Documentation Changes Required

none

[SharkyKZ]

Default template seems to work fine but setting template via URL does not, params are still missing.

[ggppdk]

@SharkyKZ
Thanks, i have fixed that case too with last commt:

The array $templates, already has parameters created for all template
then we select just template override, there is no reason to try to create parameters again

@Espionage724 @csiteru
Please test

[SharkyKZ]

I have tested this item ✅ successfully on 5b4816f

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12688.}

[csiteru]

@ggppdk I have not changed with the latest madifications. All T3 templates have default settings...

[ggppdk]

@csiteru

They may have similar problem in their custom, myself i usually use 2 other template makers, but i think have a few from them too, if i get time i might test T3 template case

• you may notify the template maker about the issue, and link to this discussion

[dgrammatiko]

I have tested this item ✅ successfully on 5b4816f

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12688.}

[jeckodevelopment]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12688.}

[zero-24]

Thanks!

[csiteru]

Hi!
I found the bug why the template style always is set default on my site on j3.6.4.
When SEF is off, in

joomla-cms/libraries/cms/application/site.php

Line 440 in 5b4816f

$item = $menu->getItem($this->input->getInt('Itemid', null));

is set right ItemId and template is set right. But is SEF is ON, This function returns 0 and $id set = 0 in line 448 ($id = $item->template_style_id). Thats why
$template = $templates[$id]; is always = 0, and template style set defaunt.

joomla-cms/libraries/cms/application/site.php

Line 506 in 5b4816f

$template = $templates[$id];

[ggppdk]

@csiteru
This is not directly related to what this PR fixes, you should open a new issue with a good description

[csiteru]

@ggppdk
Unfortunately, I can explain only very badly in English =(
I'll try to make a video

[zero-24]

Yes please open a new issue with that video than :)

[leetempest]

Does anyone have a fix when using a T3 template with two assigned styles running on 3.6.4? I have a logged in area I need to use a different template / menu system on but it is always displaying the default template when seo is turned on. Thanks

[brianteeman]

I suggest that you contact t3 diectly as we can only support issues in the
Joomla core

On 10 November 2016 at 15:52, Lee Tempest [email protected] wrote:

Does anyone have a fix when using a T3 template with two assigned styles
running on 3.6.4? I have a logged in area I need to use a different
template / menu system on but it is always displaying the default template
when seo is turned on. Thanks

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12688 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8eNJbKKwHB_mx1wT-dWrN0gTTjPAks5q8y-qgaJpZM4Kmly9
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/