[com_finder] Allow loading plugin language strings from extension folder #12204

piotr-cz · 2016-09-29T11:39:58Z

Summary of Changes

This adds functionality to load finder plugin language strings from the extension folder (just like it's happening in other places).

Testing Instructions

Move finder - categories plugin language files en-GB.plg_finder_content.ini and en-GB.plg_finder_content.sys.ini from administrator/language/en-GB folder to plugins/finder/content/language/en-GB
Go to Components > Smart Search
Index content (on toolbar click on Index)
Add new Search filter (on sidebar click on Search Filters, then on toolbar click New)
First accordion title should say Search by Author - n instead of Search by PLG_FINDER_QUERY_FILTER_BRANCH_S_AUTHOR - n

Documentation Changes Required

none

mbabker · 2016-09-29T11:56:38Z

Can you use the JPATH_PLUGINS constant?

On Thursday, September 29, 2016, Piotr [email protected] wrote:

Summary of Changes

This adds functionality to load finder plugin language strings from the
extension folder (just like it's happening in other places).
Testing Instructions

Move finder - categories plugin language files
en-GB.plg_finder_content.ini and en-GB.plg_finder_content.sys.ini from
administrator/language/en-GB folder to plugins/finder/content/
language/en-GB

Go to Menu > Components > Smart Search > Search Filters > New

First accordion title should say Search by Author - n instead of Search
by PLG_FINDER_QUERY_FILTER_BRANCH_S_AUTHOR - n

Documentation Changes Required

none

You can view, comment on, or merge this pull request online at:

#12204
Commit Summary

Allow loading plugin language strings from extension folder

File Changes

M administrator/components/com_finder/helpers/language.php
https://github.com/joomla/joomla-cms/pull/12204/files#diff-0 (5)

Patch Links:

https://github.com/joomla/joomla-cms/pull/12204.patch

https://github.com/joomla/joomla-cms/pull/12204.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12204, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfoU2fzKxZF_KbYjSb69H1Pl2msOHBks5qu6OPgaJpZM4KJ416
.

piotr-cz · 2016-09-29T12:23:38Z

Thanks, fixed.

RonakParmar · 2016-09-30T06:36:29Z

I have followed below two steps, but not able to perform 3rd step.

Move finder - categories plugin language files en-GB.plg_finder_content.ini and en-GB.plg_finder_content.sys.ini from administrator/language/en-GB folder to plugins/finder/content/language/en-GB
Go to Menu > Components > Smart Search > Search Filters > New

Not able to see "Search by Author - n" text in new search filter view.

First accordion title should say Search by Author - n instead of Search by PLG_FINDER_QUERY_FILTER_BRANCH_S_AUTHOR - n
Please guide me where I can see this text.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12204.}

infograf768 · 2016-09-30T07:06:41Z

This patch is towards 3.7.0-dev, not 3.3.7-dev
You first have to run the index.

piotr-cz · 2016-09-30T09:24:59Z

@RonakParmar
Sorry, you have to run index first. I've updated testing instructions.

RonakParmar · 2016-09-30T09:26:29Z

Thank you, I'll do it.

piotr-cz · 2016-09-30T14:32:08Z

@wilsonge Why v3.7 milestone instead of v3.6? It's a bugfix, not new feature

wilsonge · 2016-09-30T15:16:11Z

What bug is it fixing? As far as I can tell this is bringing consistency to way finder plugins load language files. But as it's never apparently been an intended thing this is the grey area but to me is more feature than bug fix

mbabker · 2016-09-30T15:17:32Z

Since 1.6 core has supported loading languages from either the global directory or within the extension (for those that support it; I think files and libraries extensions don't). So anything not supporting that lookup method to me looks like a bug and not a feature.

zero-24 · 2016-10-03T10:59:11Z

I have tested this item ✅ successfully on 404f263

👍 Thanks!

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12204.}

piotr-cz · 2016-10-09T15:39:57Z

@RonakParmar can you test again, please?

RonakParmar · 2016-10-10T03:50:18Z

Hi, Can anyone guide me, what should I have to do to make my local copy version 3.7.0-dev?
So, I can test this PR.
Thanks.

zero-24 · 2016-10-10T06:00:25Z

You can download the last build from here: https://developer.joomla.org/nightly-builds.html :)

infograf768 · 2016-10-10T06:22:45Z

I do agree this is a bug and not a new feature as a 3rd party can create a new finder plugin with its own language folder.

RonakParmar · 2016-10-10T06:27:15Z

In the first step of testing instruction

Move finder - categories plugin language files en-GB.plg_finder_content.ini and en-GB.plg_finder_content.sys.ini from administrator/language/en-GB folder to plugins/finder/content/language/en-GB

You mentioned "finder - categories plugin" and you are showing content plugin language files to move in content plugin. Is it a typing mistake?

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12204.}

RonakParmar · 2016-10-10T06:35:22Z

@zero-24 thank you for the URL.

I have downloaded full package of Joomla 3.7.0-dev and setup in my local to test this issue.
I have followed above steps but not able to reproduce this issue.
My joomla version is Joomla! 3.7.0-dev Development [ Noether ] 27-June-2016 08:13 GMT.
Without applying the PR I can language variable is not missing. attached screen dump of my local, please test it and let me know if I have done anything wrong.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12204.}

infograf768 · 2016-10-10T06:49:11Z

@RonakParmar
To test this:
before patch
Take off the 2 lang files
en-GB.plg_finder_content.ini
en-GB.plg_finder_content.sys.ini
from administrator/language/en-GB/
keep them in a safe place

you will get when creating a new filter:

Then patch and create in
plugins/finder/content/
a folder /language/en-GB/

add the fini files in this folder

Now test

RonakParmar · 2016-10-10T06:54:50Z

I have tested this item ✅ successfully on 404f263

It was my mistake, I have copied and pasted files, instead of cut and paste.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12204.}

infograf768 · 2016-10-10T07:07:16Z

RTC

@wilsonge

Please reconsider milestone.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12204.}

piotr-cz · 2016-10-10T09:28:32Z

thank you

rdeutz · 2016-10-11T19:49:33Z

Sorry was merged by mistake, thought it was based on 3.7, I am going to revert it. @piotr-cz could you please make a new PR based on the 3.7.x branch, thanks

piotr-cz · 2016-10-12T08:30:04Z

@rdeutz Are you sure this belongs to 3.7 branch (see this comment)?

rdeutz · 2016-10-12T08:49:04Z

@piotr-cz we are not merging it into 3.6.3 and I have my doubts that we will have a 3.6.4. You can make it against staging if you like.

piotr-cz · 2016-10-12T08:54:13Z

@rdeutz

I'll prepare a PR for 3.7 branch then.
This PR is against staging branch.

Allow loading plugin language strings from extension folder

fbd47c7

joomla-cms-bot added the PR-staging label Sep 29, 2016

piotr-cz changed the title ~~com_finder: Allow loading plugin language strings from extension folder~~ [com_finder] Allow loading plugin language strings from extension folder Sep 29, 2016

Use JPATH_PLUGINS instead of JPATH_SITE

404f263

mbabker approved these changes Sep 29, 2016

View reviewed changes

wilsonge added this to the Joomla 3.7.0 milestone Sep 29, 2016

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 10, 2016

rdeutz merged commit e76aefd into joomla:staging Oct 11, 2016

rdeutz mentioned this pull request Oct 11, 2016

Revert "[com_finder] Allow loading plugin language strings from extension folder" #12389

Merged

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 11, 2016

piotr-cz mentioned this pull request Oct 12, 2016

[com_finder] Allow loading plugin language strings from extension folder (branch v3.7) #12403

Merged

piotr-cz deleted the bugfix/finder-language branch October 18, 2016 18:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[com_finder] Allow loading plugin language strings from extension folder #12204

[com_finder] Allow loading plugin language strings from extension folder #12204

piotr-cz commented Sep 29, 2016 •

edited by joomla-cms-bot

Loading

mbabker commented Sep 29, 2016

none

piotr-cz commented Sep 29, 2016

RonakParmar commented Sep 30, 2016

infograf768 commented Sep 30, 2016

piotr-cz commented Sep 30, 2016

RonakParmar commented Sep 30, 2016

piotr-cz commented Sep 30, 2016 •

edited

Loading

wilsonge commented Sep 30, 2016

mbabker commented Sep 30, 2016

zero-24 commented Oct 3, 2016

piotr-cz commented Oct 9, 2016

RonakParmar commented Oct 10, 2016

zero-24 commented Oct 10, 2016

infograf768 commented Oct 10, 2016

RonakParmar commented Oct 10, 2016

RonakParmar commented Oct 10, 2016

infograf768 commented Oct 10, 2016 •

edited

Loading

RonakParmar commented Oct 10, 2016

infograf768 commented Oct 10, 2016

piotr-cz commented Oct 10, 2016

rdeutz commented Oct 11, 2016

piotr-cz commented Oct 12, 2016

rdeutz commented Oct 12, 2016

piotr-cz commented Oct 12, 2016

[com_finder] Allow loading plugin language strings from extension folder #12204

[com_finder] Allow loading plugin language strings from extension folder #12204

Conversation

piotr-cz commented Sep 29, 2016 • edited by joomla-cms-bot Loading

Summary of Changes

Testing Instructions

Documentation Changes Required

mbabker commented Sep 29, 2016

none

piotr-cz commented Sep 29, 2016

RonakParmar commented Sep 30, 2016

infograf768 commented Sep 30, 2016

piotr-cz commented Sep 30, 2016

RonakParmar commented Sep 30, 2016

piotr-cz commented Sep 30, 2016 • edited Loading

wilsonge commented Sep 30, 2016

mbabker commented Sep 30, 2016

zero-24 commented Oct 3, 2016

piotr-cz commented Oct 9, 2016

RonakParmar commented Oct 10, 2016

zero-24 commented Oct 10, 2016

infograf768 commented Oct 10, 2016

RonakParmar commented Oct 10, 2016

RonakParmar commented Oct 10, 2016

infograf768 commented Oct 10, 2016 • edited Loading

RonakParmar commented Oct 10, 2016

infograf768 commented Oct 10, 2016

piotr-cz commented Oct 10, 2016

rdeutz commented Oct 11, 2016

piotr-cz commented Oct 12, 2016

rdeutz commented Oct 12, 2016

piotr-cz commented Oct 12, 2016

piotr-cz commented Sep 29, 2016 •

edited by joomla-cms-bot

Loading

piotr-cz commented Sep 30, 2016 •

edited

Loading

infograf768 commented Oct 10, 2016 •

edited

Loading