Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Groups - removed label: enabled/disabled users #12086

Closed
wants to merge 1 commit into from
Closed

User Groups - removed label: enabled/disabled users #12086

wants to merge 1 commit into from

Conversation

pe7er
Copy link
Contributor

@pe7er pe7er commented Sep 20, 2016

On the User Groups page is the layout of the columns Enabled users and Disabled users and their columns are IMHO not nice.

Summary of Changes

This PR removes the text labels Enabled users and Disabled users so that the layout looks better and more in consistent with the similar columns of the item counters on the Category page (Content > Categories)

article-categories

Testing Instructions

Before the PR:

backend: Users > User Groups

users-groups-enabled-disabled-users-before

After the PR:

backend: Users > User Groups

users-groups-enabled-disabled-users-after

@zero-24
Copy link
Contributor

zero-24 commented Sep 20, 2016

looks much better but maybe we can move that colum a bit left atleast on desktop? As there are now much unused space:
image

@RonakParmar
Copy link

I have tested this item ✅ successfully on 612400b


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12086.

@brianteeman
Copy link
Contributor

Not in favour of this change as it is right now a we still have the clumns enabled/disabled in the users view

@tomartailored
Copy link

I have tested this item ✅ successfully on 612400b

i have tested this item successfully


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12086.

@JamalTailored
Copy link

I have tested this item ✅ successfully on 612400b


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12086.

@hans2103
Copy link
Contributor

hans2103 commented Nov 4, 2016

I have tested this item 🔴 unsuccessfully on 612400b

With this patch applied the text "Enabled users" and "Disabled users" will disappear... but due to the classes "hidden-phone hidden-tablet" on the th element the table header will disappear too. Result in meaningless columns.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12086.

@ghost
Copy link

ghost commented Jan 11, 2017

I have tested this item 🔴 unsuccessfully on 612400b

On smaller Devices the meaning of columns is not clear because some or all Icons are at
wrong position:
1
or gone
2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12086.

@korneliusz401
Copy link

I have tested this item ✅ successfully on 612400b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12086.

@brianteeman
Copy link
Contributor

Can you look at resolving the conflicts so that this can be tested please. Otherwise based on the comments above this will be closed short!y

@pe7er
Copy link
Contributor Author

pe7er commented Sep 10, 2017

I've created a new PR for this: #17924 - User Groups - removed label: enabled/disabled users v2
This PR can be closed.

@pe7er pe7er closed this Sep 10, 2017
@pe7er pe7er deleted the user-groups-enabled-disabled-users branch September 25, 2018 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants