-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unneeded metadata.xml files #11990
Conversation
Documentation Changes
|
I have tested this item ✅ successfully on bbbf934 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11990. |
Should we have these files in script.php at the same time? |
Yes
|
I didn't add them to the script.php because it doesn't really matter if they are present or not. As you see currently 😄 |
It starts to become a mess if you have some sites with files and some sites without. Especially security scanners. If the files are not needed then they should be removed This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11990. |
Added the files to the script.php. If it's not merged for 3.6.3 that files needs to be adjusted so the comment matches :) |
@photodude I had a look but couldn't find anything related to metadata.xml on a first glance. At least not where I would have expected it (https://docs.joomla.org/J3.x:Developing_an_MVC_Component/Adding_a_menu_type_to_the_site_part) |
I have tested this item ✅ successfully on 5638ec2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11990. |
5638ec2
to
a18a374
Compare
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11990. |
* Remove unneeded metadata.xml files * Remove files during update
Currently, we have metadata.xml files in each view. However since Joomla 3.5.0 those are no longer required (PR #7654).
Summary of Changes
This PR removes the metadata.xml files since they have no function at all in core.
This will help extension developers to see best practices.
Testing Instructions
Documentation Changes Required
None to my knowledge.