Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded metadata.xml files #11990

Merged
merged 2 commits into from
Nov 5, 2016
Merged

Conversation

Bakual
Copy link
Contributor

@Bakual Bakual commented Sep 8, 2016

Currently, we have metadata.xml files in each view. However since Joomla 3.5.0 those are no longer required (PR #7654).

Summary of Changes

This PR removes the metadata.xml files since they have no function at all in core.
This will help extension developers to see best practices.

Testing Instructions

  • Test creating menu items for the affected views. Nothing strange should happen.
  • Check the menu item type text in the menu item manager, see picture. Nothing should change there.
    metadata

Documentation Changes Required

None to my knowledge.

@photodude
Copy link
Contributor

photodude commented Sep 8, 2016

Documentation Changes Required Suggested

The Hello world example component code/development tutorial likely needs a major update to match with 3.5+ best practices like the removal of metadata.xml. (I think it was last revised with 3.2)

@Minei3oat
Copy link
Contributor

I have tested this item ✅ successfully on bbbf934

I didn't found a posibility to test the views of com_mailto because there are no selectable views (XML-files are missing).
All other was working.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11990.

@jsubri
Copy link
Contributor

jsubri commented Sep 8, 2016

Should we have these files in script.php at the same time?

@brianteeman
Copy link
Contributor

brianteeman commented Sep 8, 2016 via email

@Bakual
Copy link
Contributor Author

Bakual commented Sep 9, 2016

I didn't add them to the script.php because it doesn't really matter if they are present or not. As you see currently 😄
If we merge something like this #10548, they may be needed again in special cases.

@brianteeman
Copy link
Contributor

It starts to become a mess if you have some sites with files and some sites without. Especially security scanners. If the files are not needed then they should be removed


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11990.

@Bakual
Copy link
Contributor Author

Bakual commented Sep 9, 2016

Added the files to the script.php. If it's not merged for 3.6.3 that files needs to be adjusted so the comment matches :)

@Bakual
Copy link
Contributor Author

Bakual commented Sep 9, 2016

The Hello world example component code/development tutorial likely needs a major update to match with 3.5+ best practices like the removal of metadata.xml. (I think it was last revised with 3.2)

@photodude I had a look but couldn't find anything related to metadata.xml on a first glance. At least not where I would have expected it (https://docs.joomla.org/J3.x:Developing_an_MVC_Component/Adding_a_menu_type_to_the_site_part)

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 5638ec2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11990.

@zero-24
Copy link
Contributor

zero-24 commented Nov 5, 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11990.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 5, 2016
@rdeutz rdeutz merged commit d6de805 into joomla:staging Nov 5, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 5, 2016
@Bakual Bakual deleted the RemoveMetadataXml branch November 5, 2016 12:23
nvyush pushed a commit to nvyush/joomla-cms that referenced this pull request Nov 9, 2016
* Remove unneeded metadata.xml files

* Remove files during update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants